ported memo to anchor #3024
ported memo to anchor #3024
Conversation
|
Sorry, I was getting a review ready off of #3020 -- is there any difference here? |
|
This work is nice however I don't see a reason to land it in SPL. |
There was a problem hiding this comment.
Looks really great for the most part! A few small points to address on your side, and on our side we'll figure out the correct repo for this to land.
Another thing to consider is to run cargo fmt to be sure the code is automatically formatted, and cargo clippy -Zunstable-options --workspace --all-targets -- --deny=warnings
memo/anchor_program/memo/src/lib.rs
Outdated
| pub mod memo { | ||
| use super::*; | ||
| use std::str; | ||
| pub fn build_memo(ctx: Context<BuildMemo>,input:Vec<u8>) -> Result<()> { |
There was a problem hiding this comment.
nit: the name build_memo is a bit misleading, since you're actually printing the memo in your program, and not building it. Maybe log_memo would be a better name?
Also, for input, since it could be a large buffer, it's better to accept a &[u8] rather than a Vec<u8> to avoid copying.
There was a problem hiding this comment.
- Changed the function name to
log_memo - Anchor deserialize function won't allow the input to be
&[u8], tried a lot of different ways to make it happen but well Anchor complains a lot in this particular scenario.
Error:
the function or associated item `deserialize` exists for struct `instruction::LogMemo`, but its trait bounds were not satisfied
There was a problem hiding this comment.
Ah, this might be the place for zero-copy deserialization! Here's an example for you to follow: https://github.com/project-serum/anchor/blob/master/tests/zero-copy/programs/zero-copy/src/lib.rs
|
@Saviour1001 - is this worth a bump? cc @joncinque |
|
Just to be clear, I don't think we should land this PR. It can live as a separate repo as an example of how to use Anchor, but I have no opinion on where beyond not in the SPL repo |
|
Let me know where to shift this PR and I will do it. |
github-actions
bot
added
the
stale
Deployed on Devnet: 4ARKJpztrkSJXJQ8ii9pr6NjJdwKrC6M3jA8LG21tvjG
@joncinque