Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lending: Add SetLendingMarketOwner instruction #1434

Merged
merged 1 commit into from
Mar 11, 2021
Merged

lending: Add SetLendingMarketOwner instruction #1434

merged 1 commit into from
Mar 11, 2021

Conversation

jstarry
Copy link
Member

@jstarry jstarry commented Mar 11, 2021

Problem

No way to migrate an existing lending market to a new owner. In this case, I would like to move the owner authority to a multisig contract

@jstarry jstarry requested a review from jordaaash March 11, 2021 06:55
jordaaash
jordaaash approved these changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@jordaaash jordaaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I like the additional instruction docs. Had two questions but non blocking.

token-lending/program/src/instruction.rs
/// 0. `[writable]` Source liquidity token account. $authority can transfer $liquidity_amount
/// 1. `[writable]` Destination collateral token account.
/// 2. `[writable]` Reserve account.
/// 3. `[writable]` Reserve liquidity supply SPL Token account.
/// 4. `[writable]` Reserve collateral SPL Token mint.
/// 5. `[]` Lending market account.
/// 6. `[]` Derived lending market authority.
/// 7. `[]` User transfer authority ($authority).
/// 7. `[signer]` User transfer authority ($authority).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

token-lending/program/src/processor.rs Show resolved Hide resolved
token-lending/program/tests/set_lending_market_owner.rs Show resolved Hide resolved
@jstarry jstarry added the automerge Merge this pull request automatically once CI and reviews are compelte label Mar 11, 2021
@mergify mergify bot merged commit 90b4b33 into solana-labs:master Mar 11, 2021
@jstarry jstarry deleted the set-market-owner branch March 11, 2021 16:04
@jordaaash jordaaash mentioned this pull request Apr 16, 2021
Draft
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordaaash jordaaash jordaaash approved these changes

Assignees
No one assigned
Labels
automerge Merge this pull request automatically once CI and reviews are compelte
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jstarry @jordaaash