-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
token3: ensure the wrapped SOL mint is owned by the token program #374
Comments
…oken 2 program. Workaround for solana-labs/solana-program-library#374 until spl-token 3 is shipped
…oken 2 program. Workaround for solana-labs/solana-program-library#374 until spl-token 3 is shipped
…oken 2 program. Workaround for solana-labs/solana-program-library#374 until spl-token 3 is shipped
…oken 2 program. Workaround for solana-labs/solana-program-library#374 until spl-token 3 is shipped
…oken 2 program. Workaround for solana-labs/solana-program-library#374 until spl-token 3 is shipped
…oken 2 program. Workaround for solana-labs/solana-program-library#374 until spl-token 3 is shipped
…oken 2 program. Workaround for solana-labs/solana-program-library#374 until spl-token 3 is shipped
…oken 2 program. Workaround for solana-labs/solana-program-library#374 until spl-token 3 is shipped
…oken 2 program. Workaround for solana-labs/solana-program-library#374 until spl-token 3 is shipped
…oken 2 program. Workaround for solana-labs/solana-program-library#374 until spl-token 3 is shipped
…oken 2 program. Workaround for solana-labs/solana-program-library#374 until spl-token 3 is shipped
…oken 2 program. Workaround for solana-labs/solana-program-library#374 until spl-token 3 is shipped
…oken 2 program. Workaround for solana-labs/solana-program-library#374 until spl-token 3 is shipped
…oken 2 program. Workaround for solana-labs/solana-program-library#374 until spl-token 3 is shipped
…oken 2 program. Workaround for solana-labs/solana-program-library#374 until spl-token 3 is shipped
…oken 2 program. Workaround for solana-labs/solana-program-library#374 until spl-token 3 is shipped
…oken 2 program. Workaround for solana-labs/solana-program-library#374 until spl-token 3 is shipped
…oken 2 program. Workaround for solana-labs/solana-program-library#374 until spl-token 3 is shipped
…oken 2 program. Workaround for solana-labs/solana-program-library#374 until spl-token 3 is shipped
…oken 2 program. Workaround for solana-labs/solana-program-library#374 until spl-token 3 is shipped (cherry picked from commit 7341e60) # Conflicts: # core/src/rpc_service.rs # runtime/src/bank.rs
…oken 2 program. Workaround for solana-labs/solana-program-library#374 until spl-token 3 is shipped (cherry picked from commit 7341e60)
…oken 2 program. Workaround for solana-labs/solana-program-library#374 until spl-token 3 is shipped (cherry picked from commit 7341e60)
…oken 2 program. Workaround for solana-labs/solana-program-library#374 until spl-token 3 is shipped (cherry picked from commit 7341e60)
…oken 2 program. (#11974) Workaround for solana-labs/solana-program-library#374 until spl-token 3 is shipped (cherry picked from commit 7341e60) Co-authored-by: Michael Vines <[email protected]>
…oken 2 program. Workaround for solana-labs/solana-program-library#374 until spl-token 3 is shipped (cherry picked from commit 7341e60)
…oken 2 program. (#11973) Workaround for solana-labs/solana-program-library#374 until spl-token 3 is shipped (cherry picked from commit 7341e60) Co-authored-by: Michael Vines <[email protected]>
This will require RELEASE.md updates to describe how to create the native mint whenever a new version of SPL Token is deployed |
This is probably now obsolete since we made this so via a bank.rs change |
It kinda sucks that this requires core support though 😕 The alternatives kinda suck also. I've been thinking on it |
I'm sold on keeping the special case for SPL Token. It's weird and we wouldn't do it if we could rewind back six months, but it works and is in prod |
The native mint for token 2:
solana-program-library/token/program/src/native_mint.rs
Line 7 in 92457f7
has a bug in that it's an account that is not owned by the token program, and doesn't have account data that looks like every other mint account.
This requires special case handling within the token program itself and any user of SPL Token that wants to support wrapped SOL.
Instead we should make wrapped SOL mint look like any other mint account to avoid special casing (which is exactly the reason why wrapped SOL exists).
The supply for the native mint would represent the current amount of Wrapped SOL (instead of the total native SOL supply)
solana-program-library/token/program/src/state.rs
Line 23 in 92457f7
The text was updated successfully, but these errors were encountered: