Include new syscall instruction in the (dis)assembler
#611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lichtso
reviewed
Oct 10, 2024
Lichtso
reviewed
Oct 10, 2024
LucasSte
force-pushed
the
sys-ver
branch
2 times, most recently
from
d0466fe
to
415fc80
Compare
Lichtso
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solana-foundation/solana-improvement-documents#178 proposed the opcode 0x95 for syscalls in SBPFv2.
This PR modifies the assembler and the disassembler to properly deal with the new opcode and instruction format. The verifier, jitter and interpreter will be modified in follow up PRs.