jit: make sure RSP is 16 byte aligned when we call into rust code #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The System V ABI requires $rsp to be 16 bytes aligned. Internally we don't emit any instructions that require alignment but when we call out to rustc generated code we must align.
Codecov Report
@@ Coverage Diff @@
## main #523 +/- ##
==========================================
+ Coverage 89.62% 89.69% +0.06%
==========================================
Files 23 23
Lines 10303 10313 +10
==========================================
+ Hits 9234 9250 +16
+ Misses 1069 1063 -6
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The System V ABI requires $rsp to be 16 bytes aligned. Internally we don't emit any instructions that require alignment but when we call out to rustc generated code we must align.