This repository has been archived by the owner on Jan 10, 2025. It is now read-only.
Refactor - Disables little-endian byte swap instructions in SBPFv2 #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #493 +/- ##
=======================================
Coverage 89.65% 89.65%
=======================================
Files 23 23
Lines 10145 10149 +4
=======================================
+ Hits 9095 9099 +4
Misses 1050 1050
|
alessandrod
approved these changes
Aug 3, 2023
There was a problem hiding this comment.
Approving with a note that we don't have tests for the case where it's disabled. We probably don't need a test for each thing we're disabling, we could have one test_all_the_cruft_we_disabled_in_sbfv2 (not necessarily in this PR, just before we actually enable sbfv2)
18 tasks
10 tasks
nvjle
pushed a commit
to anza-xyz/llvm-project
that referenced
this pull request
Dec 21, 2023
This PR addressed two more items in solana-labs/solana#34250. It removes the little endian byte swap instructions (solana-labs/rbpf#493) and the input buffers related instructions (solana-labs/rbpf#251).
LucasSte
added a commit
to LucasSte/llvm-project
that referenced
this pull request
Jan 31, 2024
This PR addressed two more items in solana-labs/solana#34250. It removes the little endian byte swap instructions (solana-labs/rbpf#493) and the input buffers related instructions (solana-labs/rbpf#251).
LucasSte
added a commit
to anza-xyz/llvm-project
that referenced
this pull request
Feb 16, 2024
This PR addressed two more items in solana-labs/solana#34250. It removes the little endian byte swap instructions (solana-labs/rbpf#493) and the input buffers related instructions (solana-labs/rbpf#251).
LucasSte
added a commit
to LucasSte/llvm-project
that referenced
this pull request
Jun 28, 2024
This PR addressed two more items in solana-labs/solana#34250. It removes the little endian byte swap instructions (solana-labs/rbpf#493) and the input buffers related instructions (solana-labs/rbpf#251).
LucasSte
added a commit
to anza-xyz/llvm-project
that referenced
this pull request
Aug 19, 2024
This PR addressed two more items in solana-labs/solana#34250. It removes the little endian byte swap instructions (solana-labs/rbpf#493) and the input buffers related instructions (solana-labs/rbpf#251).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #354
In the LLVM backend these should be removed:
https://github.com/solana-labs/llvm-project/blob/7b8db05b564faffb522434b73b7082662171f94a/llvm/lib/Target/SBF/SBFInstrInfo.td#L901