Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor - Replaces sub r11, imm with add r11, -imm #488

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

Lichtso
Copy link

@Lichtso Lichtso commented Jul 24, 2023

That way we only need one instruction which is specific to dynamic_stack_frames and R11.

In llvm the frame lowering will need to be adjusted to emit add r11, -imm instead of sub r11, imm:
https://github.com/solana-labs/llvm-project/blob/7b8db05b564faffb522434b73b7082662171f94a/llvm/lib/Target/SBF/SBFFrameLowering.cpp#L25

@Lichtso Lichtso requested a review from alessandrod July 24, 2023 15:41
@codecov-commenter
Copy link

Codecov Report

Merging #488 (f4dcaac) into main (4c68373) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #488      +/-   ##
==========================================
+ Coverage   89.67%   89.69%   +0.01%     
==========================================
  Files          23       23              
  Lines       10105    10097       -8     
==========================================
- Hits         9062     9056       -6     
+ Misses       1043     1041       -2     
Impacted Files Coverage Δ
src/interpreter.rs 98.20% <100.00%> (+0.28%) ⬆️
src/jit.rs 92.86% <100.00%> (+0.06%) ⬆️
src/verifier.rs 97.48% <100.00%> (-0.04%) ⬇️

@Lichtso Lichtso force-pushed the refactor/stop_using_sub_imm_for_dynamic_stack_frames branch from f4dcaac to e8392c6 Compare July 24, 2023 17:10
@Lichtso Lichtso merged commit 48f271f into main Jul 25, 2023
12 checks passed
@Lichtso Lichtso deleted the refactor/stop_using_sub_imm_for_dynamic_stack_frames branch July 25, 2023 12:28
@Lichtso Lichtso mentioned this pull request Nov 28, 2023
18 tasks
nvjle pushed a commit to anza-xyz/llvm-project that referenced this pull request Dec 12, 2023
This PR replaces sub r11, imm by add r11, -imm and is the equivalent of solana-labs/rbpf#488 for the SBF target in LLVM.

This is the first task in solana-labs/solana#34250
LucasSte added a commit to LucasSte/llvm-project that referenced this pull request Jan 31, 2024
This PR replaces sub r11, imm by add r11, -imm and is the equivalent of solana-labs/rbpf#488 for the SBF target in LLVM.

This is the first task in solana-labs/solana#34250
LucasSte added a commit to anza-xyz/llvm-project that referenced this pull request Feb 16, 2024
This PR replaces sub r11, imm by add r11, -imm and is the equivalent of solana-labs/rbpf#488 for the SBF target in LLVM.

This is the first task in solana-labs/solana#34250
LucasSte added a commit to LucasSte/llvm-project that referenced this pull request Jun 28, 2024
This PR replaces sub r11, imm by add r11, -imm and is the equivalent of solana-labs/rbpf#488 for the SBF target in LLVM.

This is the first task in solana-labs/solana#34250
LucasSte added a commit to anza-xyz/llvm-project that referenced this pull request Aug 19, 2024
This PR replaces sub r11, imm by add r11, -imm and is the equivalent of solana-labs/rbpf#488 for the SBF target in LLVM.

This is the first task in solana-labs/solana#34250
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants