Feature - Restrict ro data layout in SBPFv2 #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lichtso
force-pushed
the
feature/restrict_ro_data_layout_in_sbpf_v2
branch
from
0012b16
to
465c9ce
Compare
alessandrod
reviewed
Jul 6, 2023
src/elf.rs
Outdated
| let s2 = new_section(20, 10); | ||
| let s3 = new_section(40, 10); | ||
| let s4 = new_section(50, 10); | ||
| let s1 = new_section(ebpf::MM_PROGRAM_START, 10); |
There was a problem hiding this comment.
Instead of changing the existing test, wouldn't it be better to add a new test
with this "high" vaddrs? We have code that does one thing or another depending
on whether vaddr < MM_PROGRAM_START or >. I think we should test both?
We can probably even do for base_addr in [0, MM_PROGRAM_START] { ... } as I
think the behaviour should be exactly the same
Lichtso
force-pushed
the
feature/restrict_ro_data_layout_in_sbpf_v2
branch
from
465c9ce
to
5d945b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.