Fix JIT instruction meter in syscall & unresolved symbol exceptions #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lichtso
force-pushed
the
test/nested_vm_syscall
branch
2 times, most recently
from
b6b3f33 to
d6f0f11
Compare
One in syscalls which throw an exception and one in the unresolved symbol exception.
Lichtso
force-pushed
the
test/nested_vm_syscall
branch
from
d6f0f11 to
ed20e04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unresolved symbol exception did not check if the instruction meter reached its limit earlier.
And the syscall exception did not adjust the instruction meter after the call, leaving it in a corrupted state.
This PR also introduces a new test which covers these bugs and additionally tests nested JIT VMs via syscalls.