Port the Explorer from Create React App to Next 13 (w/ App Router) #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
steveluscher
force-pushed
the
next13-port
branch
4 times, most recently
from
77cc361
to
5012edc
Compare
|
Ship it. Nothing stands out as being immediately wrong |
ngundotra
reviewed
May 8, 2023
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "typescript.tsdk": "node_modules/.pnpm/[email protected]/node_modules/typescript/lib", | |||
| "typescript.enablePromptUseWorkspaceTsdk": true | |||
There was a problem hiding this comment.
Did you mean to add this file?
There was a problem hiding this comment.
Yeah. Next 13 insists on this somehow.
|
Just checking, I see that you've renamed a bunch of files to match their paths, but other than that why are there so many diffs in +/- files (I'd expect mostly moving files) |
|
This PR breaks blame again because I didn't take care to |
This was referenced Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies in advance for this un-reviewable PR. We're porting Explorer from Create React App to the brand-new-released-yesterday Next 13 with a modern App Router.
In addition to the port, this iteration features:
pnpmLighthouse scores
Without actually fixing many of the underlying problems, the old site on the new infrastructure pulls better Lighthouse scores.