Amend SIMD-15 with latest labs implementation details #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstarry
force-pushed
the
amend-simd-15
branch
from
6e9a70a to
6bd79a2
Compare
jstarry
force-pushed
the
amend-simd-15
branch
from
6bd79a2 to
14cd87c
Compare
HaoranYi
reviewed
Jan 31, 2024
|
|
||
| ### Reward Distribution Snapshot State | ||
|
|
||
| An additional field `epoch_rewards_status` will be added to serialized bank |
There was a problem hiding this comment.
Maybe it is worth emphasizing that epoch_rewards_status are of type option. Thats means only snapshots, which are taken during reward period, store the fulllist of stake rewards. . For snapshots that are taken outside of reward period, we don't need to store the rewards.
|
Closed in favor of #118 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The labs implementation diverged from the initial SIMD 15 proposal so this change amends that proposal to reflect the labs implementation.