Only re-generate cabal file if hpack is new enough #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sol
force-pushed
the
version-check
branch
3 times, most recently
from
c6265d4 to
20108a9
Compare
That is: If a user tries to re-generate an existing cabal file with an older version of `hpack` than the one that was used to generate the existing cabal file, then do nothing.
|
@mgsloan @phadej This might be a more convenient fix for commercialhaskell/stack#1813 / commercialhaskell/stack#1815. Instead of relying on timestamps, you can just bump the version of your custom version of |
|
Seems reasonable, sticking with timestamps for now seems good too until there's some particular issue with that |
|
@mgsloan Yes, I agree that we should stick with the timestamps for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That is: If a user tries to re-generate an existing cabal file with an
older version of
hpackthan the one that was used to generate theexisting cabal file, then do nothing.