Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why does hpack not use the includes property? #355

Closed
CMCDragonkai opened this issue Feb 24, 2019 · 4 comments
Closed

Why does hpack not use the includes property? #355

CMCDragonkai opened this issue Feb 24, 2019 · 4 comments
Assignees
@mpilgrem
Labels
enhancement

Comments

@CMCDragonkai
Copy link

Cabal has the includes property: https://www.haskell.org/cabal/users-guide/developing-packages.html#pkg-field-includes

Which allows you to specify the C headers that should be included when we are compiling C code. How come this is ignored by Hpack? How does Hpack specify that C headers are needed when compiling some C code with c-sources?
@CMCDragonkai CMCDragonkai mentioned this issue Feb 24, 2019
Merged
@psibi
Copy link

psibi commented Aug 6, 2019 •
edited
Loading

@sol Would you like a PR for this ? I had to drop using hpack for a specific project because of this limitation.

@psibi
Copy link

psibi commented Aug 6, 2019

Okay, I solved it by using the field extra-source-files. So, I guess you don't really need it.

@CMCDragonkai
Copy link
Author

Can this be documented @psibi?

@mpilgrem mpilgrem self-assigned this Jun 21, 2024
mpilgrem added a commit that referenced this issue Jun 22, 2024
@mpilgrem
Fix #355 Add support for includes
b8747fc 
Follows the pattern of existing `install-includes`.
@mpilgrem mpilgrem mentioned this issue Jun 22, 2024
Closed
mpilgrem added a commit that referenced this issue Jun 22, 2024
@mpilgrem
Fix #355 Add support for includes
35a8f9b 
Follows the pattern of existing `install-includes`.
mpilgrem added a commit that referenced this issue Jun 23, 2024
@mpilgrem
Fix #355 Add support for includes
855dd1b 
Follows the pattern of existing `install-includes`.
@mpilgrem
Copy link
Collaborator

I am going to close this issue because the short answer is that GHC has ignored the includes: field in Cabal files since November 2008 (GHC 6.10.1): https://downloads.haskell.org/~ghc/6.10.1/docs/html/users_guide/release-6-10-1.html

@sol sol mentioned this issue Jun 25, 2024
Merged
RyanGlScott pushed a commit to RyanGlScott/mintty that referenced this issue Jun 25, 2024
@sol @RyanGlScott
Remove includes from .cabal-file
5a2eb5d 
This is useless at best, and a common source of confusion.

haskell/cabal#10145
sol/hpack#355
sol added a commit to sol/win32 that referenced this issue Jun 25, 2024
@sol
Remove includes from .cabal-file
81a0601 
This is useless at best, and a common source of confusion.

haskell/cabal#10145
sol/hpack#355
@sol sol mentioned this issue Jun 25, 2024
Merged
sol added a commit to sol/network that referenced this issue Jun 25, 2024
@sol
Remove includes from .cabal-file
6aa45b2 
This is useless at best, and a common source of confusion.

haskell/cabal#10145
sol/hpack#355
@sol sol mentioned this issue Jun 25, 2024
Closed
sol added a commit to sol/primitive that referenced this issue Jun 25, 2024
@sol
Remove includes from .cabal-file
192824c 
This is useless at best, and a common source of confusion.

haskell/cabal#10145
sol/hpack#355
@sol sol mentioned this issue Jun 25, 2024
Merged
sol added a commit to sol/process that referenced this issue Jun 25, 2024
@sol
Remove includes from .cabal-file
bf5e4b9 
This is useless at best, and a common source of confusion.

haskell/cabal#10145
sol/hpack#355
@sol sol mentioned this issue Jun 25, 2024
Merged
sol added a commit to sol/bytestring that referenced this issue Jun 25, 2024
@sol
Remove includes from .cabal-file
96795cb 
This is useless at best, and a common source of confusion.

haskell/cabal#10145
sol/hpack#355
sol added a commit to sol/old-time that referenced this issue Jun 25, 2024
@sol
Remove includes from .cabal-file
cd877f2 
This is useless at best, and a common source of confusion.

haskell/cabal#10145
sol/hpack#355
@sol sol mentioned this issue Jun 25, 2024
Open
sol added a commit to sol/ghcup-hs that referenced this issue Jun 25, 2024
@sol
Remove includes from .cabal-file
6ec91da 
This is useless at best, and a common source of confusion.

haskell/cabal#10145
sol/hpack#355
This was referenced Jun 25, 2024
Merged
Merged
sol added a commit to sol/bzlib that referenced this issue Jun 25, 2024
@sol
Remove includes from .cabal-file
9c8722a 
This is useless at best, and a common source of confusion.

haskell/cabal#10145
sol/hpack#355
@sol sol mentioned this issue Jun 25, 2024
Open
This was referenced Jun 25, 2024
Merged
Merged
andrewthad pushed a commit to haskell/primitive that referenced this issue Jun 25, 2024
@sol @andrewthad
Remove includes from .cabal-file
efde5a7 
This is useless at best, and a common source of confusion.

haskell/cabal#10145
sol/hpack#355
Bodigrim pushed a commit to haskell/zlib that referenced this issue Jun 25, 2024
@sol @Bodigrim
Remove includes from .cabal-file
4369f27 
This is useless at best, and a common source of confusion.

haskell/cabal#10145
sol/hpack#355
hasufell pushed a commit to haskell/unix that referenced this issue Jun 26, 2024
@sol @hasufell
Remove includes from .cabal-file
4f7f168 
This is useless at best, and a common source of confusion.

haskell/cabal#10145
sol/hpack#355
clyring pushed a commit to haskell/bytestring that referenced this issue Jun 26, 2024
@sol
Remove includes from .cabal-file (#685)
0e0526b 
This is useless at best, and a common source of confusion.

haskell/cabal#10145
sol/hpack#355
tomjaguarpaw pushed a commit to haskell/process that referenced this issue Jul 1, 2024
@sol @tomjaguarpaw
Remove includes from .cabal-file
ead14c2 
This is useless at best, and a common source of confusion.

haskell/cabal#10145
sol/hpack#355
Mistuke pushed a commit to haskell/win32 that referenced this issue Aug 27, 2024
@sol @Mistuke
Remove includes from .cabal-file
6b5bc04 
This is useless at best, and a common source of confusion.

haskell/cabal#10145
sol/hpack#355
Bodigrim pushed a commit to haskell/bytestring that referenced this issue Oct 9, 2024
@sol @Bodigrim
Remove includes from .cabal-file (#685)
2d6624b 
This is useless at best, and a common source of confusion.

haskell/cabal#10145
sol/hpack#355
Bodigrim pushed a commit to haskell/bytestring that referenced this issue Oct 15, 2024
@sol @Bodigrim
Remove includes from .cabal-file (#685)
1f3d4cc 
This is useless at best, and a common source of confusion.

haskell/cabal#10145
sol/hpack#355
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mpilgrem mpilgrem

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sol @CMCDragonkai @psibi @mpilgrem