Fix consistency of calculations at first time step #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
|
Kudos, SonarCloud Quality Gate passed! |
martinmoraga
force-pushed
the
voltage-source-delay
branch
from
17b96ef
to
313bcf2
Compare
martinmoraga
force-pushed
the
voltage-source-delay
branch
3 times, most recently
from
863319b
to
d2b4f3a
Compare
martinmoraga
force-pushed
the
voltage-source-delay
branch
2 times, most recently
from
fa007cd
to
6755617
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
martinmoraga
force-pushed
the
voltage-source-delay
branch
2 times, most recently
from
dcae6a8
to
ba44853
Compare
Closed
dinkelbachjan
force-pushed
the
voltage-source-delay
branch
from
ba44853
to
3f2d744
Compare
Signed-off-by: Martin Moraga <[email protected]>
Signed-off-by: Martin Moraga <[email protected]>
Signed-off-by: Martin Moraga <[email protected]>
Signed-off-by: Martin Moraga <[email protected]>
Signed-off-by: Martin Moraga <[email protected]>
Signed-off-by: Martin Moraga <[email protected]>
Signed-off-by: Martin Moraga <[email protected]>
martinmoraga
force-pushed
the
voltage-source-delay
branch
from
3f2d744
to
e47069e
Compare
Signed-off-by: Martin Moraga <[email protected]>
martinmoraga
force-pushed
the
voltage-source-delay
branch
from
7c5370e
to
a8e3e49
Compare
Signed-off-by: martin.moraga <[email protected]>
martinmoraga
force-pushed
the
voltage-source-delay
branch
from
a8e3e49
to
f2a0cee
Compare
Signed-off-by: Jan Dinkelbach <[email protected]>
dinkelbachjan
force-pushed
the
voltage-source-delay
branch
from
246ef70
to
4a79f7f
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
dinkelbachjan
approved these changes
Nov 27, 2023
dinkelbachjan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that the calculation of the first simulation step means the calculation of the values for the time instant
t=mTimeStep, whilet=0is covered by the initialization values. This was not consistently the case, in particular forEMT::Ph3::VoltageSource, which caused corresponding transients at the beginning of some simulations. Moreover, a small error in the intialization of the EMT Power Transformer is fixed. Besides, the scaling of voltages and currents has been harmonised, which is documented now underdocs/Development/Guidelines.Closes #195