Add Cimpy 3_0 #40
Open
Add Cimpy 3_0 #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steffen Vogel <[email protected]>
Signed-off-by: Steffen Vogel <[email protected]>
Signed-off-by: Steffen Vogel <[email protected]>
Signed-off-by: Steffen Vogel <[email protected]>
Signed-off-by: Steffen Vogel <[email protected]>
Signed-off-by: Steffen Vogel <[email protected]>
Signed-off-by: Steffen Vogel <[email protected]>
Signed-off-by: Steffen Vogel <[email protected]>
Signed-off-by: Steffen Vogel <[email protected]>
Signed-off-by: Steffen Vogel <[email protected]>
Signed-off-by: Steffen Vogel <[email protected]>
Signed-off-by: Steffen Vogel <[email protected]>
Signed-off-by: Steffen Vogel <[email protected]>
Signed-off-by: Steffen Vogel <[email protected]>
Signed-off-by: Steffen Vogel <[email protected]>
Signed-off-by: Steffen Vogel <[email protected]>
Signed-off-by: Steffen Vogel <[email protected]>
Okay, this PR got a bit larger than anticipated. But there were just too many small things which I want to cleanup: - General code-style: - Formatting via [black](https://github.com/psf/black) - PEP-8 compliance via [flake8](https://flake8.pycqa.org/en/3.1.1/index.html) - Fix a bunch of code-smells detected by Sonar Cloud - Improve code-quality - Remove `print()` and replace by `logging` module - Replace `.format()`-style string formatting by printf-style for logging module - Revamp CI pipelines: - I removed the in-repo CI action for building the documentation and converted it to a normal workflow - This allowed removing a lot of stuff: - Dockerfile - docu.sh - action.yaml - entrypoint.sh - Removal of GitLab CI config - The documentation is now also build in PR pipelines, but just not deployed. - Migrate to more modern Python packaging practices: - `setup.py` has been replace by `pyproject.toml` - Check code-style, formatting and more with [pre-commit](https://pre-commit.com/) - Will also be enforced by CI workflow
Signed-off-by: Steffen Vogel <[email protected]>
…pages (sogno-platform#32) This is just a small follow-up PR for sogno-platform#30 I forgot to set the proper permissions for the GitHub actions workflow which deploys the documentation to GitHub pages.
Signed-off-by: Steffen Vogel <[email protected]>
Signed-off-by: Steffen Vogel <[email protected]>
Signed-off-by: Steffen Vogel <[email protected]>
Signed-off-by: Markus Mirz <[email protected]>
Relicense cimpy as explained in sogno-platform#31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! We changed the cimpy 3 branch to add a fully functioning version of cimpy 3. Feel free to review it, we want this to become open source relatively quickly to be usable via python package index.
Regards
Thomas