Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix class and attribute types #40

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Fix class and attribute types #40

wants to merge 22 commits into from

Conversation

tom-hg57
Copy link
Collaborator

@tom-hg57 tom-hg57 commented Oct 27, 2024 •
edited
Loading

Most important changes:

  • Common:
    • Fix some attribute types
    • Fix handling of Decimal as float class
    • Add class property "is_a_primitive_class" and attribute property "is_primitive_float_attribute"
    • Improve _get_attribute_type in cimgen.py
    • Improve setting of long profile names
    • Refactor _merge_profiles and _merge_classes in cimgen.py
  • cpp:
    • Add generation of string classes (including Date, DateTime, MonthDay)
    • Fix create_class_assign functions to prevent duplicate entries in attributes with attribute_type list
    • Add static cpp sources and parser classes (copied from libcimpp)
    • Simplify and unify templates
  • modernpython:
    • Fix type and default of some attributes (for enums and attribute types Date, DateTime, MonthDay, Status, StreetAddress, StreetDetail, TownDetail)

@tom-hg57
Fix some attribute types in classes DiagramObjectGluePoint, VCompIEEE…
7944f6e 
…Type2, WindContPType3IEC for cpp and modernpython

Signed-off-by: Thomas Günther <[email protected]>
@tom-hg57
Add class property "is_a_primitive_class" and attribute property "is_…
3b6e9d2 
…primitive_float_attribute"

Signed-off-by: Thomas Günther <[email protected]>
@tom-hg57
Fix type and default of some attributes for modernpython (for enums a…
bded89c 
…nd attribute types Date, DateTime, MonthDay, Status, StreetAddress, StreetDetail, TownDetail)

Signed-off-by: Thomas Günther <[email protected]>
@tom-hg57
Fix handling of Decimal as float class
037dc1c 
Signed-off-by: Thomas Günther <[email protected]>
@tom-hg57
Remove generation of unused classes for modernpython
08dfa2e 
Signed-off-by: Thomas Günther <[email protected]>
@tom-hg57
Improve setting of long profile names
4ad48d7 
Signed-off-by: Thomas Günther <[email protected]>
@tom-hg57
Refactor _merge_profiles and _merge_classes in cimgen.py
ac487b3 
Signed-off-by: Thomas Günther <[email protected]>
@tom-hg57
Fix attribute type of TieFlow in class Terminal for cpp and modernpython
4ce0983 
Signed-off-by: Thomas Günther <[email protected]>
@tom-hg57
Add generation of string classes for cpp
7c3a497 
Signed-off-by: Thomas Günther <[email protected]>
@tom-hg57
Improve cpp templates: make debugstring() const
68f0df3 
Signed-off-by: Thomas Günther <[email protected]>
@tom-hg57
Add generated-via-cimgen comment to the header of all generated files…
c6aa544 
… for cpp

Signed-off-by: Thomas Günther <[email protected]>
@tom-hg57
Improve cpp templates (skip empty comments, improve indentations)
8e4855e 
Signed-off-by: Thomas Günther <[email protected]>
@tom-hg57
Fix cpp create_assign functions for string attribute types (Date, Dat…
04a1c99 
…eTime, MonthDay)

Signed-off-by: Thomas Günther <[email protected]>
@tom-hg57
Fix cpp create_class_assign functions to prevent duplicate entries in…
2409049 
… attributes with attribute_type list

Signed-off-by: Thomas Günther <[email protected]>
@tom-hg57
Add class comment to cpp templates for float and string classes
ed8eb99 
Signed-off-by: Thomas Günther <[email protected]>
@tom-hg57
Simplify and unify cpp templates for enum, float and string classes
1833e80 
Signed-off-by: Thomas Günther <[email protected]>
@tom-hg57
Unify formatting of the generated cpp classes
450ff19 
Signed-off-by: Thomas Günther <[email protected]>
@tom-hg57
Add static cpp sources and parser classes (copied from libcimpp)
6e09334 
Signed-off-by: Thomas Günther <[email protected]>
@tom-hg57
Remove String, Date, Float from static directory (they are now genera…
75a69ae 
…ted)

Signed-off-by: Thomas Günther <[email protected]>
@tom-hg57
Update static cpp sources and parser classes to new generated String …
c60c319 
…class; unify BaseClass, Integer, Boolean with generated classes; fix debugstring() in UnknownType

Signed-off-by: Thomas Günther <[email protected]>
@tom-hg57
Fix unused import (pre-commit flake8: cimgen/cimgen.py:5:1: F401 're'…
ab563b3 
… imported but unused)

Signed-off-by: Thomas Günther <[email protected]>
@tom-hg57 tom-hg57 force-pushed the fix-class-and-attribute-types branch from ad41d88 to ab563b3 Compare October 31, 2024 02:23
@m-mirz
Copy link
Contributor

m-mirz commented Nov 8, 2024

@tom-hg57 could you please add a description summarizing the most important changes? The same goes for #41

@tom-hg57
Add dependency to setuptools to fix ModuleNotFoundError for distutils…
997988e 
… in modernpython/lang_pack.py

Signed-off-by: Thomas Günther <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chicco785 chicco785 chicco785 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tom-hg57 @m-mirz @chicco785