Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 3.0.0 build in makefile and document makefile usage #37

Merged

Conversation

chicco785
Copy link
Collaborator

@chicco785 chicco785 commented Oct 16, 2024

This PR introduces support for CGMES 3.0.0 in Makefile and documents its usage.

@chicco785 chicco785 force-pushed the fix-makefile-and-docs branch from e745e45 to 4ba294c Compare October 16, 2024 11:55
@chicco785 chicco785 requested review from stv0g and m-mirz October 16, 2024 11:57
@chicco785 chicco785 force-pushed the fix-makefile-and-docs branch 3 times, most recently from 24635d9 to d9d59d4 Compare October 16, 2024 12:15
Signed-off-by: Federico M. Facca <[email protected]>
@chicco785 chicco785 force-pushed the fix-makefile-and-docs branch from 281019c to e8da018 Compare October 16, 2024 12:16
@m-mirz
Copy link
Contributor

m-mirz commented Oct 30, 2024

@chicco785 It would be great if you could amend your commits in order to avoid having these commits adding and removing the DS_Store file.

Copy link
Contributor

@m-mirz m-mirz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A short PR description would be nice ;-)

@m-mirz m-mirz self-assigned this Nov 8, 2024
Copy link
Contributor

@m-mirz m-mirz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could be merged after resolving my previous comment about amending some commits.

Signed-off-by: Federico M. Facca <[email protected]>

Delete .DS_Store

Signed-off-by: Federico M. Facca <[email protected]>

Update build.yaml

Signed-off-by: Federico M. Facca <[email protected]>

Delete cgmes_schema/.DS_Store

Signed-off-by: Federico M. Facca <[email protected]>

Update build.yaml

Signed-off-by: Federico M. Facca <[email protected]>
@chicco785 chicco785 force-pushed the fix-makefile-and-docs branch from e8da018 to 6e07123 Compare November 10, 2024 17:30
Copy link

@chicco785 chicco785 requested a review from m-mirz November 15, 2024 12:45
Copy link
Contributor

@m-mirz m-mirz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first commit is still adding the files and the second deleting them but I will just squash merge this.

@m-mirz m-mirz merged commit cf5b986 into sogno-platform:master Nov 16, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants