Add generation of CGMES profile class #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tom-hg57
commented
Aug 11, 2024
•
tom-hg57
commented
- Add generation of CGMESProfile class (including profile URIs) for python
- Improve generation of CGMESProfile class for javascript
- Add cim namespace to the generated CGMESProfile class
- Add method Profile.uris() to CGMESProfile.py to get the list of profile URIs
- Add recommended class profile to all generated classes (currently only used for python: Add generation of CGMES profile class cimpy#39)
Signed-off-by: Thomas Günther <[email protected]>
…4_15 from baseURIs to entsoeURIs (e.g. http://entsoe.eu/CIM/Topology/4/1) Signed-off-by: Thomas Günther <[email protected]>
Signed-off-by: Thomas Günther <[email protected]>
Signed-off-by: Thomas Günther <[email protected]>
…le URIs Signed-off-by: Thomas Günther <[email protected]>
stv0g
changed the title
…y used for python) Signed-off-by: Thomas Günther <[email protected]>
|
|
Ready for review. |
|
@tom-hg57 Thanks! Can you please add some context in the PR description? |
m-mirz
approved these changes
Sep 21, 2024
|
I cant really comment on the details. But overall the code looks fine to me. |
m-mirz
added a commit
to sogno-platform/cimpy
that referenced
this pull request
Oct 30, 2024
Depends on cimgen pull request: sogno-platform/cimgen#35, which is already merged now. In my repo all workflows run successfully: tom-hg57#1 (even deploying of github-pages). Improve cimexport.py using profile URIs (from new generated CGMESProfile.py) in model description of exported cim files - Update generated python files created by cimgen - Use profile URIs (from new generated CGMESProfile.py) in model description of exported cim files - Fix "Package information not found" for EquipmentBoundary and ToplogyBoundary in cim_import() by using new generated CGMESProfile.py - Fix export for data read without profile information - Improve cim_export (activeProfileList is now optional - no activeProfileList means output to all profile files with data) - Add function cim_export_to_string_array - Fix model ID in cim_export (must be unique across all files) - Use recommended class profile from new generated classes (if data is read without profile information, or some objects are added after import) - Improve .github/workflows/test.yaml - Update documentation in cimpy/cimexport.py With the new generated python files created by cimgen the issue #23 is solved. PR #24 could be closed if this PR is merged. The same applies to issue #25 and PR #26.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.