Implement multipart body support in sttp stub #4117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe. |
adamw
reviewed
Oct 24, 2024
server/sttp-stub-server/src/test/scala/sttp/tapir/server/stub/TapirStubInterpreterTest.scala
Show resolved
Hide resolved
|
@adamw Hi! I’ve resolved all the issues and added a new test for handling multipartBody[T] with custom type T. Could you take a look? |
adamw
reviewed
Oct 29, 2024
server/sttp-stub-server/src/test/scala/sttp/tapir/server/stub/TapirStubInterpreterTest.scala
Outdated
Show resolved
Hide resolved
adamw
reviewed
Oct 29, 2024
server/sttp-stub-server/src/test/scala/sttp/tapir/server/stub/TapirStubInterpreterTest.scala
Outdated
Show resolved
Hide resolved
adamw
reviewed
Oct 29, 2024
server/sttp-stub-server/src/test/scala/sttp/tapir/server/stub/TapirStubInterpreterTest.scala
Show resolved
Hide resolved
adamw
reviewed
Oct 29, 2024
server/sttp-stub-server/src/test/scala/sttp/tapir/server/stub/TapirStubInterpreterTest.scala
Outdated
Show resolved
Hide resolved
|
Thanks this looks better now - I think we're close to being done, I left some comments regarding extending the test cases |
|
@adamw I have worked on this including files. Can I raise a new PR? Or Collaborate here ? |
adamw
reviewed
Oct 30, 2024
server/sttp-stub-server/src/main/scala/sttp/tapir/server/stub/SttpRequestBody.scala
Outdated
Show resolved
Hide resolved
|
@asr2003 This PR looks fine, I think the functionality is there, so if you'd have some comments on how to improve the code, that would be most welcome |
adamw
reviewed
Oct 31, 2024
server/sttp-stub-server/src/main/scala/sttp/tapir/server/stub/SttpRequestBody.scala
Outdated
Show resolved
Hide resolved
adamw
reviewed
Oct 31, 2024
server/sttp-stub-server/src/main/scala/sttp/tapir/server/stub/SttpRequestBody.scala
Show resolved
Hide resolved
adamw
reviewed
Oct 31, 2024
server/sttp-stub-server/src/main/scala/sttp/tapir/server/stub/SttpRequestBody.scala
Outdated
Show resolved
Hide resolved
adamw
reviewed
Oct 31, 2024
server/sttp-stub-server/src/main/scala/sttp/tapir/server/stub/SttpRequestBody.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started by creating a test case that replicated the error. After that, I worked on resolving the issue until the test case passed successfully.
/claim #3902