Generate anyOf schema for oneOfVariants with the same status code and content-type
#3703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susliko
force-pushed
the
scame-ct-oneof-variants
branch
from
cb2bda3 to
e8fc8ad
Compare
|
@ghik approves of using Thanks! Just waiting for the build to finish |
ghik
reviewed
Apr 19, 2024
Comment on lines
+115
to
+116
| example = bodies.flatMap(_.example).headOption, | ||
| examples = bodies.flatMap(_.examples).toListMap |
There was a problem hiding this comment.
example and examples are mutually exclusive, we should fill only one of them
There was a problem hiding this comment.
I think the problem might be present elsewhere as well, however we probably only ever generate example based on tapir's schemas. Let's move it to another issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3660
Chose to use
anyOf(notoneOf) because there's no discriminator and we cannot guarantee that only one model will match.