Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala 3 support for Seq / IndexedSeq #91

Merged
merged 3 commits into from
Apr 28, 2022

Conversation

OndrejSpanel
Copy link
Contributor

PR for #90

Added tests which check Seq / IndexedSeq functionality (copied from List ones).

Tests currently pass on Scala 2 and fail on Scala 3.

I intend to implement the functionality within a few days.

@OndrejSpanel
Copy link
Contributor Author

OndrejSpanel commented Apr 23, 2022

I have very simple solution which seems working, obtained by copying List functors for Seq / IndexedSeq. I hope to come with something more generic, but my Scala 3 experience is very limited (and frankly I am not very comfortable with higher-kinded types even in Scala 2, my head scratches when I think about them).

If someone has some advice / suggestion, or a link to a similar functionality in another library, feel free to chime in.

@OndrejSpanel
Copy link
Contributor Author

I implemented a generic solution for any containers implementing Seq, copied from how Map is currently implemented. It looks generic enough and it passed my tests, therefore I think it is ready for review.

@OndrejSpanel OndrejSpanel marked this pull request as ready for review April 23, 2022 20:07
@adamw adamw merged commit 93581d8 into softwaremill:master Apr 28, 2022
@adamw
Copy link
Member

adamw commented Apr 28, 2022

Thanks! Looks good :)

@OndrejSpanel OndrejSpanel deleted the seq-index branch April 28, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants