Relax type constraint for QuicklensMapAt #78
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I relaxed a type constraint for
implicit class QuicklensMapAt
. Previously it works only on subtypes of theMap
type. With this PR it will work for any type with the instance ofQuicklensMapAtFunctor
typeclass.Real-world use-case: newtype wrapping
Map
. It may not have subtype relationships but could work like aMap
. In my codebase, I have a customNonEmptyMap
, for example.Relaxing type constraint leads to an implicit resolution ambiguity: compiler can't choose between
QuicklensFunctor
andQuicklensMapAtFunctor
foreach
calls. To fix this I movedimplicit class QuicklensEach
into theLowPriorityImplicits
trait.Overall it is a safe change in terms of API. All old code will work without changes.