Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parameter validation to grouped* operators #165

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Add parameter validation to grouped* operators #165

merged 2 commits into from
Jun 27, 2024

Conversation

micossow
Copy link
Contributor

No description provided.

kciesielski
kciesielski reviewed Jun 27, 2024
View reviewed changes
Copy link
Member

@kciesielski kciesielski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

** suggestion ** use require() (see throttle). Could you also change it in sliding?

@micossow micossow merged commit a6c115a into master Jun 27, 2024
5 checks passed
@micossow micossow deleted the grouped-parameter-validation branch June 27, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kciesielski kciesielski kciesielski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@micossow @kciesielski