File I/O #139
Merged
File I/O #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamw
reviewed
May 14, 2024
adamw
reviewed
May 14, 2024
adamw
reviewed
May 14, 2024
adamw
reviewed
May 14, 2024
kciesielski
commented
May 15, 2024
kciesielski
commented
May 15, 2024
|
Thanks :) |
adamw
reviewed
May 20, 2024
| */ | ||
| def fromFile(path: Path, chunkSize: Int = 1024)(using Ox): Source[Chunk[Byte]] = | ||
| if Files.isDirectory(path) then throw new IOException(s"Path $path is a directory") | ||
| val chunks = StageCapacity.newChannel[Chunk[Byte]] |
There was a problem hiding this comment.
btw @kciesielski here we could have an implicit StageCapacity as well
adamw
reviewed
May 20, 2024
| chunks.done() | ||
| false | ||
| else if readBytes == 0 then | ||
| chunks.send(Chunk.empty) |
There was a problem hiding this comment.
and re-reading this, is there any point in sending empty chunks? ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #137