Parse BlockId on forge's side -> remove starknet dependency
#941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotmag769
requested review from
maciektr,
MaksymilianDemitraszek,
cptartur,
Arcticae and
war-in
and removed request for
mkaput
piotmag769
changed the title
BlockId on forge's side -> remove starknet dependency
5 tasks
piotmag769
commented
Nov 24, 2023
extensions/scarb-snforge-test-collector/src/compilation/test_collector/config.rs
Show resolved
Hide resolved
extensions/scarb-snforge-test-collector/src/compilation/test_collector/config.rs
Show resolved
Hide resolved
extensions/scarb-snforge-test-collector/src/compilation/test_collector/config.rs
Show resolved
Hide resolved
piotmag769
force-pushed
the
remove-starknet-dependency
branch
from
0995aa3
to
f26d6d4
Compare
cptartur
reviewed
Nov 27, 2023
extensions/scarb-snforge-test-collector/src/compilation/test_collector/config.rs
Outdated
Show resolved
Hide resolved
extensions/scarb-snforge-test-collector/src/compilation/test_collector/config.rs
Show resolved
Hide resolved
piotmag769
force-pushed
the
remove-starknet-dependency
branch
from
f26d6d4
to
84c212c
Compare
piotmag769
force-pushed
the
remove-starknet-dependency
branch
from
84c212c
to
28ef795
Compare
cptartur
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
foundry-rs/starknet-foundry#1193
Changes:
BlockIdstructurestarknet-rsdependency from ScarbBlockId::Tagbug ParseBlockIdon forge's side -> remove starknet dependency #941 (comment)