-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull core
from starkware-libs/cairo.git
#84
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkaput
force-pushed
the
mkaput/download-corelib
branch
2 times, most recently
from
February 21, 2023 15:12
e429891
to
489a5b2
Compare
It started to be too tedious to maintain.
…n logic 1. Using `include_dir` instead of `rust_embed`, because the former supports build script-set compile-time envs expansion. 2. Replaced `download_package_to_cache` with more up-to-date approach, based on nesting PathSource. 3. Cache directory layout is now tagged with Cairo version and is called `std` instead of `core`, with additional space for adding more "standard" packages in the future.
mkaput
force-pushed
the
mkaput/download-corelib
branch
from
February 21, 2023 15:13
489a5b2
to
d18ccc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #78