Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass scarb env vars #71

Merged
merged 5 commits into from
Feb 22, 2023
Merged

Pass scarb env vars #71

merged 5 commits into from
Feb 22, 2023

Conversation

maciektr
Copy link
Contributor

@maciektr maciektr commented Feb 10, 2023 •
edited
Loading

fix #8, fix #64

mkaput
mkaput requested changes Feb 13, 2023
View reviewed changes
Copy link
Member

@mkaput mkaput left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing only verbosity flag value to SCARB_LOG is imprecise, because SCARB_LOG is much more powerful, for example it allows granular filtering based on log event target (docs).

I think what should be passed is a stringified representation of the EnvFilter that is built in main.

Ideally, I would like to infer this from tracing rather than requiring passing to Config/UI, but I couldn't find a way to do so.

scarb/src/core/config.rs Outdated Show resolved Hide resolved
@mkaput
Copy link
Member

mkaput commented Feb 14, 2023

I am doing more high-level verbosity representation in #69

@mkaput
Copy link
Member

mkaput commented Feb 17, 2023

Passing only verbosity flag value to SCARB_LOG is imprecise, because SCARB_LOG is much more powerful, for example it allows granular filtering based on log event target (docs).

I think what should be passed is a stringified representation of the EnvFilter that is built in main.

Ideally, I would like to infer this from tracing rather than requiring passing to Config/UI, but I couldn't find a way to do so.

I was wrong here. Let's discuss this topic in the office next week

@maciektr maciektr force-pushed the maciektr/env branch 3 times, most recently from bd67d10 to 8575e9b Compare February 20, 2023 14:45
@maciektr maciektr marked this pull request as ready for review February 21, 2023 08:41
@maciektr maciektr requested a review from mkaput February 21, 2023 08:42
mkaput
mkaput requested changes Feb 21, 2023
View reviewed changes
scarb/tests/e2e/build.rs Outdated Show resolved Hide resolved
scarb/tests/e2e/subcommand.rs Outdated Show resolved Hide resolved
scarb/src/ops/subcommands.rs Outdated Show resolved Hide resolved
mkaput
mkaput requested changes Feb 22, 2023
View reviewed changes
scarb/src/core/config.rs Outdated Show resolved Hide resolved
scarb/src/ui/mod.rs Outdated Show resolved Hide resolved
scarb/src/ui/mod.rs Outdated Show resolved Hide resolved
scarb/tests/e2e/subcommand.rs Outdated Show resolved Hide resolved
@mkaput
Copy link
Member

mkaput commented Feb 22, 2023

Please rebase, so that each commit resolves one topic

@maciektr maciektr requested a review from mkaput February 22, 2023 08:57
mkaput
mkaput approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻

scarb/src/ui/mod.rs Outdated Show resolved Hide resolved
@maciektr maciektr added this pull request to the merge queue Feb 22, 2023
Merged via the queue into main with commit 4f8ac1b Feb 22, 2023
@maciektr maciektr deleted the maciektr/env branch February 22, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkaput mkaput mkaput approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@maciektr @mkaput