Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify information about package names in docs #296

Merged
merged 1 commit into from
May 4, 2023
Merged

Clarify information about package names in docs #296

merged 1 commit into from
May 4, 2023

Conversation

mkaput
Copy link
Member

@mkaput mkaput commented May 2, 2023

  • Remove package name regex from docs
  • Explicitly state that it must not be a Cairo keyword

@mkaput
Clarify information about package names in docs
25a17cc 
- Remove package name regex from docs
- Explicitly state that it must not be a Cairo keyword

Signed-off-by: Marek Kaput <[email protected]>
@mkaput mkaput requested review from maciektr and piotmag769 May 2, 2023 07:17
@mkaput mkaput added this pull request to the merge queue May 4, 2023
Merged via the queue into main with commit f396273 May 4, 2023
@mkaput mkaput deleted the mkaput-patch-1 branch May 4, 2023 11:52
piotmag769
piotmag769 reviewed May 4, 2023
View reviewed changes
Copy link
Contributor

@piotmag769 piotmag769 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't the code allow for packages starting with the underscore though?
@mkaput @maciektr

https://github.com/software-mansion/scarb/blob/main/scarb/src/core/package/name.rs#LL47C8-L47C8

@mkaput
Copy link
Member Author

mkaput commented May 4, 2023

Ah, right, I'll fix docs

@mkaput mkaput mentioned this pull request May 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotmag769 piotmag769 piotmag769 left review comments

@maciektr maciektr maciektr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkaput @maciektr @piotmag769