Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cairo-language-server binary #260

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Add cairo-language-server binary #260

merged 1 commit into from
Apr 28, 2023

Conversation

maciektr
Copy link
Contributor

@maciektr maciektr commented Apr 17, 2023 •
edited
Loading

fix #221

mkaput
mkaput reviewed Apr 17, 2023
View reviewed changes
scarb/Cargo.toml Outdated Show resolved Hide resolved
@maciektr maciektr force-pushed the maciektr/cairo-ls-bundled branch 2 times, most recently from 31f91f9 to 68d50a2 Compare April 18, 2023 12:45
@mkaput mkaput mentioned this pull request Apr 19, 2023
Closed
@maciektr maciektr force-pushed the maciektr/cairo-ls-bundled branch 5 times, most recently from 611e84f to 542c292 Compare April 26, 2023 13:11
@maciektr maciektr marked this pull request as ready for review April 27, 2023 13:21
@maciektr maciektr requested a review from mkaput April 27, 2023 13:21
mkaput
mkaput approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please push a tag v0.2.0-test.0 and see whether it properly builds and runs

Then please remove the tag & ensure it's not present on GitHub releases. And then we can merge this 🚀

@maciektr maciektr temporarily deployed to github-pages April 27, 2023 23:03 — with GitHub Actions Inactive
@mkaput mkaput merged commit 7a8087a into main Apr 28, 2023
@mkaput mkaput deleted the maciektr/cairo-ls-bundled branch April 28, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkaput mkaput mkaput approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Language Server extension
2 participants
@maciektr @mkaput