Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code mappings for attribute expand (temp) #1657

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

maciektr
Copy link
Contributor

No description provided.

@maciektr maciektr marked this pull request as ready for review October 18, 2024 13:01
Copy link
Contributor

@wawel37 wawel37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be sure, we only want to disable it for attributes, right? Because i see that we are still returning mappings for Derives.

@maciektr
Copy link
Contributor Author

@wawel37 TBH I only care about them for attr, but you are right we might just as well remove for other types for consistency. Pushed changes.

@maciektr maciektr added this pull request to the merge queue Oct 24, 2024
Merged via the queue into main with commit 6798b12 Oct 24, 2024
22 checks passed
@maciektr maciektr deleted the maciektr/code-map branch October 24, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants