Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile contract artifacts in test targets #1585

Merged
merged 9 commits into from
Sep 20, 2024
Merged

Compile contract artifacts in test targets #1585

merged 9 commits into from
Sep 20, 2024

Conversation

maciektr
Copy link
Contributor

@maciektr maciektr commented Sep 9, 2024

  • Refactor starknet-contract compiler
  • Emit starknet contracts in test targets

@maciektr maciektr force-pushed the maciektr/test-target branch 5 times, most recently from e2cf31d to 9619404 Compare September 18, 2024 07:33
@maciektr maciektr changed the title maciektr/test target Compile contract artifacts in test targets Sep 18, 2024
@maciektr maciektr marked this pull request as ready for review September 18, 2024 07:34
wawel37
wawel37 approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@wawel37 wawel37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

scarb/src/compiler/compilers/starknet_contract.rs Outdated Show resolved Hide resolved
scarb/src/compiler/compilers/starknet_contract.rs Outdated Show resolved Hide resolved
scarb/src/core/manifest/target.rs Show resolved Hide resolved
cptartur
cptartur reviewed Sep 18, 2024
View reviewed changes
Copy link
Member

@cptartur cptartur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not verify the logic, but generated artefacts make sense to me.

wawel37
wawel37 reviewed Sep 19, 2024
View reviewed changes
Copy link
Contributor

@wawel37 wawel37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tbh I don't understand all the logic behind this, but other than that looks good

scarb/src/compiler/compilers/starknet_contract/artifacts_writer.rs Outdated Show resolved Hide resolved
scarb/src/compiler/compilers/starknet_contract/artifacts_writer.rs Outdated Show resolved Hide resolved
scarb/src/compiler/compilers/starknet_contract/artifacts_writer.rs Outdated Show resolved Hide resolved
@maciektr maciektr added this pull request to the merge queue Sep 20, 2024
Merged via the queue into main with commit 9bcab97 Sep 20, 2024
22 checks passed
@maciektr maciektr deleted the maciektr/test-target branch September 20, 2024 15:48
@BrewTestBot BrewTestBot mentioned this pull request Sep 26, 2024
Merged
@maciektr maciektr mentioned this pull request Oct 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cptartur cptartur cptartur left review comments

@wawel37 wawel37 wawel37 approved these changes

@ddoktorski ddoktorski ddoktorski approved these changes

@DelevoXDG DelevoXDG Awaiting requested review from DelevoXDG DelevoXDG is a code owner

@integraledelebesgue integraledelebesgue Awaiting requested review from integraledelebesgue

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maciektr @wawel37 @ddoktorski @cptartur