Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support more ModuleItems in proc macro attribute expansion #1556

Merged
merged 4 commits into from
Sep 18, 2024
Merged

Support more ModuleItems in proc macro attribute expansion #1556

merged 4 commits into from
Sep 18, 2024

Conversation

maciektr
Copy link
Contributor

@maciektr maciektr commented Aug 28, 2024 •
edited
Loading

fix #1532

@maciektr maciektr force-pushed the maciektr/proc-macro branch 2 times, most recently from 96a323d to b609d1e Compare September 2, 2024 12:06
@maciektr maciektr marked this pull request as ready for review September 2, 2024 12:06
wawel37
wawel37 reviewed Sep 12, 2024
View reviewed changes
Copy link
Contributor

@wawel37 wawel37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it would be great that someone with better context would look at it.

scarb/tests/build_cairo_plugin.rs Show resolved Hide resolved
scarb/src/compiler/plugin/proc_macro/host.rs Show resolved Hide resolved
@maciektr maciektr added this pull request to the merge queue Sep 18, 2024
Merged via the queue into main with commit 6ae5547 Sep 18, 2024
22 checks passed
@maciektr maciektr deleted the maciektr/proc-macro branch September 18, 2024 11:42
@BrewTestBot BrewTestBot mentioned this pull request Sep 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wawel37 wawel37 wawel37 left review comments

@THenry14 THenry14 Awaiting requested review from THenry14

@DelevoXDG DelevoXDG Awaiting requested review from DelevoXDG DelevoXDG is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support proc macro attributes on module item impl
2 participants
@maciektr @wawel37