starknet_multiple_contracts example refurbishment #1543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dent shape and clearly indicate answer() method as read.
stranger80
requested review from
maciektr,
THenry14 and
DelevoXDG
as code owners
maciektr
approved these changes
Aug 26, 2024
|
Thank you for pointing this out @stranger80 ! 🔥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The https://github.com/software-mansion/scarb/blob/main/examples/starknet_multiple_contracts/src/forty_two.cairo sample included a 'shorthand' styled contract code (no explicitly specified contract interface), and the
answer()method is interpreted as a 'write' method by the compiler, even though it does not alter state.The proposed contract code is hopefully less confusing.