-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract package metadata info + refactor #1460
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotmag769
requested review from
maciektr,
THenry14 and
DelevoXDG
as code owners
July 17, 2024 13:58
This was referenced Jul 17, 2024
piotmag769
requested review from
mkaput and
Arcticae
and removed request for
THenry14 and
DelevoXDG
July 17, 2024 14:00
piotmag769
commented
Jul 17, 2024
piotmag769
force-pushed
the
spr/main/b9eb7559
branch
from
July 17, 2024 14:04
3a6eb5f
to
4498259
Compare
This was referenced Jul 17, 2024
Merged
mkaput
approved these changes
Jul 17, 2024
piotmag769
force-pushed
the
spr/main/b9eb7559
branch
from
July 17, 2024 14:59
4498259
to
2f0cf18
Compare
Arcticae
approved these changes
Jul 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few nitpicks
piotmag769
force-pushed
the
spr/main/b9eb7559
branch
from
July 18, 2024 08:41
2f0cf18
to
6aa9369
Compare
commit-id:b9eb7559
piotmag769
force-pushed
the
spr/main/b9eb7559
branch
from
July 18, 2024 09:50
6aa9369
to
6ed17ae
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit-id:b9eb7559
Stack: