Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort [dependencies] section on scarb add #143

Merged
merged 4 commits into from
Mar 3, 2023
Merged

Sort [dependencies] section on scarb add #143

merged 4 commits into from
Mar 3, 2023

Conversation

kariy
Copy link
Contributor

@kariy kariy commented Mar 2, 2023 •
edited
Loading

Fix #128

Will sort if the [dependencies] section is already sorted otherwise leave it as is.

@mkaput mkaput self-requested a review March 3, 2023 08:40
mkaput
mkaput requested changes Mar 3, 2023
View reviewed changes
Copy link
Member

@mkaput mkaput left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I just have two non-critical suggestions :) Thanks a lot for this contribution!

Note: I'll merge this to main branch, but this won't land in Scarb 0.1. We don't want to release new features in RC period.

In the future, please leave a comment under an issue that you'd like to tackle it, like you used to do in the past. Thanks to this comment, I can assign you to the issue 😄

scarb/src/manifest_editor/add.rs Outdated Show resolved Hide resolved
scarb/tests/e2e/add.rs Show resolved Hide resolved
@kariy
Copy link
Contributor Author

kariy commented Mar 3, 2023

This looks good! I just have two non-critical suggestions :) Thanks a lot for this contribution!

Note: I'll merge this to main branch, but this won't land in Scarb 0.1. We don't want to release new features in RC period.

In the future, please leave a comment under an issue that you'd like to tackle it, like you used to do in the past. Thanks to this comment, I can assign you to the issue 😄

Yeah my bad 😓. I initially wanted to take this along with the other one, but when I opened the PR I realized I forgot to ask for this one first. Won't happen again, sir. 🫡

@mkaput
Copy link
Member

mkaput commented Mar 3, 2023

Yeah my bad 😓. I initially wanted to take this along with the other one, but when I opened the PR I realized I forgot to ask for this one first. Won't happen again, sir. 🫡

No worries!

mkaput
mkaput approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

♥️♥️♥️♥️♥️

@mkaput mkaput added this pull request to the merge queue Mar 3, 2023
Merged via the queue into software-mansion:main with commit 036d14a Mar 3, 2023
@kariy kariy deleted the refactor/sort branch March 7, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkaput mkaput mkaput approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sort [dependencies] section in scarb add
2 participants
@kariy @mkaput