Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DocGroup in scarb-doc #1409

Merged
merged 3 commits into from
Jul 4, 2024
Merged

DocGroup in scarb-doc #1409

merged 3 commits into from
Jul 4, 2024

Conversation

piotmag769
Copy link
Contributor

No description provided.

@piotmag769 piotmag769 requested review from mkaput and Arcticae and removed request for THenry14 and DelevoXDG July 3, 2024 18:33
@piotmag769 piotmag769 force-pushed the doc-group branch 3 times, most recently from 1adffc7 to 40926ae Compare July 3, 2024 18:38
maciektr
maciektr approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@maciektr maciektr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

extensions/scarb-doc/Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Show resolved Hide resolved
@piotmag769 piotmag769 requested a review from maciektr July 3, 2024 21:39
mkaput
mkaput approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Leaving some suggestions that you can apply here or other PRs :)

extensions/scarb-doc/src/types.rs Show resolved Hide resolved
extensions/scarb-doc/src/db.rs Show resolved Hide resolved
extensions/scarb-doc/src/db.rs Show resolved Hide resolved
extensions/scarb-doc/src/db.rs Show resolved Hide resolved
@piotmag769 piotmag769 enabled auto-merge July 4, 2024 09:51
@piotmag769 piotmag769 added this pull request to the merge queue Jul 4, 2024
Merged via the queue into main with commit b0a31a4 Jul 4, 2024
22 checks passed
@piotmag769 piotmag769 deleted the doc-group branch July 4, 2024 11:08
@BrewTestBot BrewTestBot mentioned this pull request Aug 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkaput mkaput mkaput approved these changes

@Arcticae Arcticae Awaiting requested review from Arcticae

@maciektr maciektr Awaiting requested review from maciektr maciektr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piotmag769 @mkaput @maciektr