Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory managment around the FFI-barrier #1174

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Fix memory managment around the FFI-barrier #1174

merged 1 commit into from
Mar 7, 2024

Conversation

maciektr
Copy link
Contributor

@maciektr maciektr commented Mar 5, 2024 •
edited
Loading

commit-id:e557eb16

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

This was referenced Mar 5, 2024
Closed
Merged
Merged
Merged
@maciektr maciektr marked this pull request as ready for review March 5, 2024 23:11
@maciektr maciektr requested a review from szymmis as a code owner March 5, 2024 23:11
mkaput
mkaput requested changes Mar 7, 2024
View reviewed changes
Copy link
Member

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed offline, let's postpone fixing these issues and just leak memory as for now

@maciektr maciektr enabled auto-merge March 7, 2024 11:51
@maciektr maciektr added this pull request to the merge queue Mar 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 7, 2024
@maciektr maciektr enabled auto-merge March 7, 2024 13:31
@maciektr maciektr added this pull request to the merge queue Mar 7, 2024
Merged via the queue into main with commit 7cb6bed Mar 7, 2024
21 checks passed
@maciektr maciektr deleted the spr/main/e557eb16 branch March 7, 2024 13:41
@BrewTestBot BrewTestBot mentioned this pull request Mar 9, 2024
Merged
@BrewTestBot BrewTestBot mentioned this pull request Aug 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkaput mkaput mkaput approved these changes

@szymmis szymmis Awaiting requested review from szymmis

@MaksymilianDemitraszek MaksymilianDemitraszek Awaiting requested review from MaksymilianDemitraszek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maciektr @mkaput