Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken layout for header subviews in iOS #902

Merged
merged 3 commits into from
May 7, 2021
Merged

Fix broken layout for header subviews in iOS #902

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c3d1ce3
Fix broken layout for header subviews in iOS (Fixes #528)
abram Apr 30, 2021
16ec49e
Move code to prevent incorrect header subview positioning
abram May 4, 2021
7b2faaa
Update ios/RNSScreenStackHeaderConfig.m
abram May 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ios/RNSScreenStackHeaderConfig.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,13 @@ - (instancetype)initWithBridge:(RCTBridge *)bridge
return self;
}

- (void) reactSetFrame:(CGRect)frame
{
// Block any attempt to set coordinates a RNSScreenStackHeaderSubview. This
// allows the native UINavigationBar to control the position of header content.
abram marked this conversation as resolved.
Show resolved Hide resolved
[super reactSetFrame:CGRectMake(0, 0, frame.size.width, frame.size.height)];
}

@end

@implementation RNSScreenStackHeaderConfig {
Expand Down