Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: try upgrading to rn-77 #2573

Closed
wants to merge 1 commit into from

Conversation

vonovak
Copy link

@vonovak vonovak commented Dec 13, 2024

Description

when updating dependencies for RN 77, I get this during pod install in the fabric example. I'd appreciate if a maintainer could have a look at this and make the pod install step work. Thank you! :)

logs
Found 6 modules for target `FabricExample`
link_native_modules! {:ios_packages=>[{:configurations=>[], :name=>"react-native-gesture-handler", :root=>"/Users/vojta/_dev/react-native-screens/FabricExample/node_modules/react-native-gesture-handler", :path=>"../node_modules/react-native-gesture-handler", :podspec_path=>"/Users/vojta/_dev/react-native-screens/FabricExample/node_modules/react-native-gesture-handler/RNGestureHandler.podspec", :script_phases=>[]}, {:configurations=>[], :name=>"react-native-reanimated", :root=>"/Users/vojta/_dev/react-native-screens/FabricExample/node_modules/react-native-reanimated", :path=>"../node_modules/react-native-reanimated", :podspec_path=>"/Users/vojta/_dev/react-native-screens/FabricExample/node_modules/react-native-reanimated/RNReanimated.podspec", :script_phases=>[]}, {:configurations=>[], :name=>"react-native-restart", :root=>"/Users/vojta/_dev/react-native-screens/FabricExample/node_modules/react-native-restart", :path=>"../node_modules/react-native-restart", :podspec_path=>"/Users/vojta/_dev/react-native-screens/FabricExample/node_modules/react-native-restart/react-native-restart.podspec", :script_phases=>[]}, {:configurations=>[], :name=>"react-native-safe-area-context", :root=>"/Users/vojta/_dev/react-native-screens/FabricExample/node_modules/react-native-safe-area-context", :path=>"../node_modules/react-native-safe-area-context", :podspec_path=>"/Users/vojta/_dev/react-native-screens/FabricExample/node_modules/react-native-safe-area-context/react-native-safe-area-context.podspec", :script_phases=>[]}, {:configurations=>[], :name=>"react-native-screens", :root=>"/Users/vojta/_dev/react-native-screens/FabricExample/node_modules/react-native-screens", :path=>"../node_modules/react-native-screens", :podspec_path=>"/Users/vojta/_dev/react-native-screens/FabricExample/node_modules/react-native-screens/RNScreens.podspec", :script_phases=>[]}, {:configurations=>[], :name=>"react-native-vector-icons", :root=>"/Users/vojta/_dev/react-native-screens/FabricExample/node_modules/react-native-vector-icons", :path=>"../node_modules/react-native-vector-icons", :podspec_path=>"/Users/vojta/_dev/react-native-screens/FabricExample/node_modules/react-native-vector-icons/RNVectorIcons.podspec", :script_phases=>[]}], :ios_project_root_path=>"/Users/vojta/_dev/react-native-screens/FabricExample/ios", :react_native_path=>"../node_modules/react-native"}
Auto-linking React Native modules for target `FabricExample`: RNGestureHandler, RNReanimated, RNScreens, RNVectorIcons, react-native-restart, and react-native-safe-area-context
Framework build type is static library
[Codegen] warn: using experimental new codegen integration
[Codegen] Adding script_phases to ReactCodegen.
[Codegen] Generating ./build/generated/ios/ReactCodegen.podspec.json

[!] Invalid `Podfile` file: [!] /opt/homebrew/bin/node ./../node_modules/react-native/scripts/generate-codegen-artifacts.js -p /Users/vojta/_dev/react-native-screens/FabricExample/ios/.. -o /Users/vojta/_dev/react-native-screens/FabricExample/ios -t ios

[Codegen] Analyzing /Users/vojta/_dev/react-native-screens/FabricExample/package.json
[Codegen] Searching for codegen-enabled libraries in the app.
[Codegen] The "codegenConfig" field is not defined in package.json. Assuming there is nothing to generate at the app level.
[Codegen] Searching for codegen-enabled libraries in the project dependencies.
[Codegen] Found react-native
[Codegen] Found react-native-gesture-handler
[Codegen] Found react-native-reanimated
[Codegen] Found react-native-safe-area-context
[Codegen] Found react-native-screens
[Codegen] Searching for codegen-enabled libraries in react-native.config.js
[Codegen] Processing FBReactNativeSpec
[Codegen] Searching for podspec in the project dependencies.
[Codegen] Processing rncore
[Codegen] Searching for podspec in the project dependencies.
[Codegen] Processing rngesturehandler_codegen
[Codegen] Searching for podspec in the project dependencies.
[Codegen] Supported Apple platforms: ios, macos, tvos, visionos for rngesturehandler_codegen
[Codegen] Processing rnreanimated
[Codegen] Searching for podspec in the project dependencies.
[Codegen] Supported Apple platforms: ios, macos, tvos, visionos for rnreanimated
[Codegen] Processing safeareacontext
[Codegen] Searching for podspec in the project dependencies.
[Codegen] Supported Apple platforms: ios, macos, tvos, visionos for safeareacontext
[Codegen] Processing rnscreens
[Codegen] Searching for podspec in the project dependencies.
[Codegen] Supported Apple platforms: ios, tvos, visionos for rnscreens
[Codegen] [Codegen - FBReactNativeSpec] Skipping iOS code generation for FBReactNativeSpec as it has been generated already.
[Codegen] [Codegen - rncore] Skipping iOS code generation for rncore as it has been generated already.
[Codegen] Generating Native Code for rngesturehandler_codegen - ios
[Codegen] Generated artifacts: /Users/vojta/_dev/react-native-screens/FabricExample/ios/build/generated/ios
[Codegen] Generating Native Code for rnreanimated - ios
[Codegen] Generated artifacts: /Users/vojta/_dev/react-native-screens/FabricExample/ios/build/generated/ios
[Codegen] Generating Native Code for safeareacontext - ios
[Codegen] Generated artifacts: /Users/vojta/_dev/react-native-screens/FabricExample/ios/build/generated/ios
[Codegen] Generating Native Code for rnscreens - ios
[Codegen] Generated artifacts: /Users/vojta/_dev/react-native-screens/FabricExample/ios/build/generated/ios
[Codegen] Generating RCTThirdPartyComponentsProvider.h
[Codegen] Generated artifact: /Users/vojta/_dev/react-native-screens/FabricExample/ios/build/generated/ios/RCTThirdPartyComponentsProvider.h
[Codegen] Generating RCTThirdPartyComponentsProvider.mm
[Codegen] Crawling react-native-gesture-handler library for components
[Codegen] Match found RNGestureHandlerButton -> RNGestureHandlerButtonComponentView
[Codegen] [DEPRECATED] react-native-gesture-handler should add the 'ios.componentProvider' property in their codegenConfig
[Codegen] Crawling react-native-safe-area-context library for components
[Codegen] Match found RNCSafeAreaProvider -> RNCSafeAreaProviderComponentView
[Codegen] Match found RNCSafeAreaView -> RNCSafeAreaViewComponentView
[Codegen] [DEPRECATED] react-native-safe-area-context should add the 'ios.componentProvider' property in their codegenConfig
[Codegen] Crawling react-native-screens library for components
[Codegen] Match found RNGestureHandlerButton -> RNGestureHandlerButtonComponentView
[Codegen] Match found RNCSafeAreaProvider -> RNCSafeAreaProviderComponentView
[Codegen] Match found RNCSafeAreaView -> RNCSafeAreaViewComponentView
[Codegen] Match found RNGestureHandlerButton -> RNGestureHandlerButtonComponentView
[Codegen] Match found RNCSafeAreaProvider -> RNCSafeAreaProviderComponentView
[Codegen] Match found RNCSafeAreaView -> RNCSafeAreaViewComponentView
[Codegen] Match found RNGestureHandlerButton -> RNGestureHandlerButtonComponentView
[Codegen] Match found RNCSafeAreaProvider -> RNCSafeAreaProviderComponentView
[Codegen] Match found RNCSafeAreaView -> RNCSafeAreaViewComponentView
[Codegen] Match found RNGestureHandlerButton -> RNGestureHandlerButtonComponentView
[Codegen] Match found RNCSafeAreaProvider -> RNCSafeAreaProviderComponentView
[Codegen] Match found RNCSafeAreaView -> RNCSafeAreaViewComponentView
[Codegen] Match found RNGestureHandlerButton -> RNGestureHandlerButtonComponentView
[Codegen] Match found RNCSafeAreaProvider -> RNCSafeAreaProviderComponentView
[Codegen] Match found RNCSafeAreaView -> RNCSafeAreaViewComponentView
[Codegen] Match found RNGestureHandlerButton -> RNGestureHandlerButtonComponentView
[Codegen] Match found RNCSafeAreaProvider -> RNCSafeAreaProviderComponentView
[Codegen] Match found RNCSafeAreaView -> RNCSafeAreaViewComponentView
[Codegen] Match found RNGestureHandlerButton -> RNGestureHandlerButtonComponentView
[Codegen] Match found RNCSafeAreaProvider -> RNCSafeAreaProviderComponentView
[Codegen] Match found RNCSafeAreaView -> RNCSafeAreaViewComponentView
[Codegen] Match found RNGestureHandlerButton -> RNGestureHandlerButtonComponentView
[Codegen] Match found RNCSafeAreaProvider -> RNCSafeAreaProviderComponentView
[Codegen] Match found RNCSafeAreaView -> RNCSafeAreaViewComponentView
[Codegen] Match found RNGestureHandlerButton -> RNGestureHandlerButtonComponentView
[Codegen] Match found RNCSafeAreaProvider -> RNCSafeAreaProviderComponentView
[Codegen] Match found RNCSafeAreaView -> RNCSafeAreaViewComponentView
[Codegen] Match found RNGestureHandlerButton -> RNGestureHandlerButtonComponentView
[Codegen] Match found RNCSafeAreaProvider -> RNCSafeAreaProviderComponentView
[Codegen] Match found RNCSafeAreaView -> RNCSafeAreaViewComponentView
[Codegen] Match found RNGestureHandlerButton -> RNGestureHandlerButtonComponentView
[Codegen] Match found RNCSafeAreaProvider -> RNCSafeAreaProviderComponentView
[Codegen] Match found RNCSafeAreaView -> RNCSafeAreaViewComponentView
[Codegen] Match found RNGestureHandlerButton -> RNGestureHandlerButtonComponentView
[Codegen] Match found RNCSafeAreaProvider -> RNCSafeAreaProviderComponentView
[Codegen] Match found RNCSafeAreaView -> RNCSafeAreaViewComponentView
[Codegen] Match found RNGestureHandlerButton -> RNGestureHandlerButtonComponentView
[Codegen] Match found RNCSafeAreaProvider -> RNCSafeAreaProviderComponentView
[Codegen] Match found RNCSafeAreaView -> RNCSafeAreaViewComponentView
[Codegen] Match found RNGestureHandlerButton -> RNGestureHandlerButtonComponentView
[Codegen] Match found RNCSafeAreaProvider -> RNCSafeAreaProviderComponentView
[Codegen] Match found RNCSafeAreaView -> RNCSafeAreaViewComponentView
[Codegen] Match found RNGestureHandlerButton -> RNGestureHandlerButtonComponentView
[Codegen] Match found RNCSafeAreaProvider -> RNCSafeAreaProviderComponentView
[Codegen] Match found RNCSafeAreaView -> RNCSafeAreaViewComponentView
[Codegen] Match found RNGestureHandlerButton -> RNGestureHandlerButtonComponentView
[Codegen] Match found RNCSafeAreaProvider -> RNCSafeAreaProviderComponentView
[Codegen] Match found RNCSafeAreaView -> RNCSafeAreaViewComponentView
[Codegen] Match found RNGestureHandlerButton -> RNGestureHandlerButtonComponentView
[Codegen] Match found RNCSafeAreaProvider -> RNCSafeAreaProviderComponentView
[Codegen] Match found RNCSafeAreaView -> RNCSafeAreaViewComponentView
[Codegen] Match found RNGestureHandlerButton -> RNGestureHandlerButtonComponentView
[Codegen] Match found RNCSafeAreaProvider -> RNCSafeAreaProviderComponentView
[Codegen] Match found RNCSafeAreaView -> RNCSafeAreaViewComponentView
[Codegen] Match found RNGestureHandlerButton -> RNGestureHandlerButtonComponentView
[Codegen] Match found RNCSafeAreaProvider -> RNCSafeAreaProviderComponentView
[Codegen] Match found RNCSafeAreaView -> RNCSafeAreaViewComponentView
[Codegen] Error: ENAMETOOLONG: name too long, open '/Users/vojta/_dev/react-native-screens/FabricExample/node_modules/react-native-screens/FabricExample/node_modules/react-native-screens/FabricExample/node_modules/react-native-screens/FabricExample/node_modules/react-native-screens/FabricExample/node_modules/react-native-screens/FabricExample/node_modules/react-native-screens/FabricExample/node_modules/react-native-screens/FabricExample/node_modules/react-native-screens/FabricExample/node_modules/react-native-screens/FabricExample/node_modules/react-native-screens/FabricExample/node_modules/react-native-screens/FabricExample/node_modules/react-native-screens/FabricExample/node_modules/react-native-screens/FabricExample/node_modules/react-native-screens/FabricExample/node_modules/react-native-screens/FabricExample/node_modules/react-native-screens/FabricExample/node_modules/react-native-screens/FabricExample/node_modules/react-native-screens/FabricExample/node_modules/react-native-screens/FabricExample/ios/build/generated/ios/rngesturehandler_codegen/rngesturehandler_codegen-generated.mm'
[Codegen] Done.
Could not find class name for component RNGestureHandlerRootView. Register it manually
Could not find class name for component RNGestureHandlerRootView. Register it manually
Could not find class name for component RNGestureHandlerRootView. Register it manually
Could not find class name for component RNGestureHandlerRootView. Register it manually
Could not find class name for component RNGestureHandlerRootView. Register it manually
Could not find class name for component RNGestureHandlerRootView. Register it manually
Could not find class name for component RNGestureHandlerRootView. Register it manually
Could not find class name for component RNGestureHandlerRootView. Register it manually
Could not find class name for component RNGestureHandlerRootView. Register it manually
Could not find class name for component RNGestureHandlerRootView. Register it manually
Could not find class name for component RNGestureHandlerRootView. Register it manually
Could not find class name for component RNGestureHandlerRootView. Register it manually
Could not find class name for component RNGestureHandlerRootView. Register it manually
Could not find class name for component RNGestureHandlerRootView. Register it manually
Could not find class name for component RNGestureHandlerRootView. Register it manually
Could not find class name for component RNGestureHandlerRootView. Register it manually
Could not find class name for component RNGestureHandlerRootView. Register it manually
Could not find class name for component RNGestureHandlerRootView. Register it manually
Could not find class name for component RNGestureHandlerRootView. Register it manually
Could not find class name for component RNGestureHandlerRootView. Register it manually
.

 #  from /Users/vojta/_dev/react-native-screens/FabricExample/ios/Podfile:23
 #  -------------------------------------------
 #  
 >    use_react_native!(
 #      :path => config[:reactNativePath],
 #  -------------------------------------------

Changes

Test code and steps to reproduce

use the PR branch to reproduce

Checklist

@kkafar
Copy link
Member

kkafar commented Dec 13, 2024

🤦🏻 on me - I haven't picked up in the conversation that you refer to 0.77, even though looking this morning I see you mentioned it explicitly. Indeed, we do not have support for 0.77 yet, so I guess it's expected something does not work there.

@kkafar
Copy link
Member

kkafar commented Dec 18, 2024

I'm working on 0.77 support in #2581

@kkafar kkafar closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants