Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added missing icon and launch screen to fabric example #2268

Merged
merged 4 commits into from
Jul 30, 2024
Merged

fix: added missing icon and launch screen to fabric example #2268

merged 4 commits into from
Jul 30, 2024

Conversation

alduzy
Copy link
Member

@alduzy alduzy commented Jul 30, 2024 •
edited
Loading

Description

This PR adds missing icon and launch screen to FabricExample app.
After copying the icons from paper example i noticed there are icons for iPad and the example itself supports iPad platform. Thus I decided to add the iPad support to fabric example as well.

Changes

  • added iOS icons and launch screen
  • added iPad support
  • added android icons and launch screen

Screenshots / GIFs

Before

Screenshot 2024-07-30 at 11 13 17
Screenshot 2024-07-30 at 11 15 08

After

Screenshot 2024-07-30 at 13 20 29
Screenshot 2024-07-30 at 12 54 53

Checklist

  • Ensured that CI passes

@alduzy alduzy requested review from tboba, WoLewicki and kkafar July 30, 2024 09:16
@tboba
Copy link
Member

tboba commented Jul 30, 2024

Great change! Just leaving one suggestion here.
In Reanimated, Example app and FabricExample app have different app icons. This allows the developer to visually distinguish app with old and new arch. Can we do something similar there? I would go for having an outline version of logo in FabricExample app, something like in our docs (maybe with gradient kept?) - you can find the logo here.

image

For reference, I'm also leaving links for reanimated logos:
https://github.com/software-mansion/react-native-reanimated/blob/main/apps/paper-example/android/app/src/main/ic_launcher-playstore.png
https://github.com/software-mansion/react-native-reanimated/blob/main/apps/fabric-example/android/app/src/main/ic_launcher-playstore.png

@kkafar
Copy link
Member

kkafar commented Jul 30, 2024

I've also thought of that @tboba, but I don't think we have such graphic ready. Unless @alduzy can rustle one up in half an hour, otherwise I'm for merging this PR as is.

@alduzy
Copy link
Member Author

alduzy commented Jul 30, 2024

I've replaced the icon on fabric as @tboba suggested 😉

@kkafar
Copy link
Member

kkafar commented Jul 30, 2024

Murarz tynkarz akrobata

Nice

kkafar
kkafar approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A load of new kilobytes for our repository (that hurts me), but fine :D 🟢

@alduzy alduzy merged commit 325f27e into main Jul 30, 2024
3 checks passed
@alduzy alduzy deleted the @alduzy/fabric-example-icons-and-launch branch July 30, 2024 14:36
@WesleyR10 WesleyR10 mentioned this pull request Aug 21, 2024
Open
@shonore shonore mentioned this pull request Aug 22, 2024
Open
@2lambda123 2lambda123 mentioned this pull request Aug 22, 2024
Merged
@Cabreira97 Cabreira97 mentioned this pull request Aug 23, 2024
Closed
This was referenced Aug 23, 2024
Open
Open
Open
Open
@2lambda123 2lambda123 mentioned this pull request Aug 26, 2024
Merged
This was referenced Aug 27, 2024
Open
Open
Open
Open
Open
Open
Open
@shonore shonore mentioned this pull request Sep 3, 2024
Open
@undrthegraveyard undrthegraveyard mentioned this pull request Sep 4, 2024
Closed
@asraful-cse asraful-cse mentioned this pull request Sep 6, 2024
Open
This was referenced Sep 24, 2024
Open
Open
Open
Open
Open
Open
@Ayush-Bulbule Ayush-Bulbule mentioned this pull request Oct 2, 2024
Merged
@tobistudio tobistudio mentioned this pull request Oct 3, 2024
Open
ja1ns pushed a commit to WiseOwlTech/react-native-screens that referenced this pull request Oct 9, 2024
@alduzy @ja1ns
fix: added missing icon and launch screen to fabric example (software…
60169d6 
…-mansion#2268)

## Description

This PR adds missing icon and launch screen to `FabricExample` app.
After copying the icons from paper example i noticed there are icons for
iPad and the example itself supports iPad platform. Thus I decided to
add the iPad support to fabric example as well.

## Changes

- added iOS icons and launch screen
- added iPad support
- added android icons and launch screen

## Screenshots / GIFs

### Before
![Screenshot 2024-07-30 at 11 13
17](https://github.com/user-attachments/assets/791dd46d-7e4a-4e54-bcfa-20893255dfe3)
![Screenshot 2024-07-30 at 11 15
08](https://github.com/user-attachments/assets/98c9d114-270c-4ccf-b876-b7215ee70a43)

### After
![Screenshot 2024-07-30 at 13 20
29](https://github.com/user-attachments/assets/c1c29c73-fd5b-4f33-820d-424fea6fdf15)
![Screenshot 2024-07-30 at 12 54
53](https://github.com/user-attachments/assets/1d033532-4d5b-465d-9289-19da50674013)


## Checklist

- [x] Ensured that CI passes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkafar kkafar kkafar approved these changes

@tboba tboba Awaiting requested review from tboba

@WoLewicki WoLewicki Awaiting requested review from WoLewicki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alduzy @tboba @kkafar