fix(Android): missing negation in check for mismatched frames #2214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alduzy
approved these changes
Jun 27, 2024
| @@ -51,7 +51,7 @@ class RNSScreenComponentDescriptor final | |||
| // state update. | |||
| if (screenShadowNode.getFrameCorrectionModes().check( | |||
| FrameCorrectionModes::Mode::FrameHeightCorrection) && | |||
| compareFrameSizes( | |||
| !compareFrameSizes( | |||
There was a problem hiding this comment.
We could consider changing the name of this function to something like checkIsFrameSizeEqual so that it's obvious what it returns.
There was a problem hiding this comment.
I think this is good suggestion. compare may suggest inequality, right?
I'll do it in separate PR, thanks!
alduzy
pushed a commit
that referenced
this pull request
Jun 28, 2024
## Description The error check was bad - it reported error each time the frames were the same. Obviously it shoud report frame mismatch. ## Changes Added missing negation. ## Checklist - [x] Ensured that CI passes
This was referenced Aug 23, 2024
This was referenced Aug 27, 2024
This was referenced Sep 24, 2024
This was referenced Sep 26, 2024
ja1ns
pushed a commit
to WiseOwlTech/react-native-screens
that referenced
this pull request
Oct 9, 2024
…re-mansion#2214) ## Description The error check was bad - it reported error each time the frames were the same. Obviously it shoud report frame mismatch. ## Changes Added missing negation. ## Checklist - [x] Ensured that CI passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The error check was bad - it reported error each time the frames were the same.
Obviously it shoud report frame mismatch.
Changes
Added missing negation.
Checklist