Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(android): Implement missing codegen interfaces #2163

Merged
merged 5 commits into from
May 29, 2024

Conversation

maciekstosio
Copy link
Contributor

Description

Currently when we change native props autogenerated by codegen we need to manually update changed files. We're going to automate so everything is copied automatically, but as a first step we need to implement those that aren't yet. This is what this PR introduces.

Test code and steps to reproduce

Go through Example app, nothing should change.

Copy link
Member

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change the PR title to more reasonable one (respect conventional commits).

Provided that you change the PR title & you've tested this I think we're good to go.

@maciekstosio maciekstosio changed the title @maciekstosio/implement missing codegen interfaces chore(android): Implement missing codegen interfaces May 29, 2024
@maciekstosio maciekstosio merged commit a9ad998 into main May 29, 2024
4 checks passed
@maciekstosio maciekstosio deleted the @maciekstosio/Implement-missing-codegen-interfaces branch May 29, 2024 09:09
ja1ns pushed a commit to WiseOwlTech/react-native-screens that referenced this pull request Oct 9, 2024
…n#2163)

## Description

Currently when we change native props autogenerated by codegen we need
to manually update changed files. We're going to automate so everything
is copied automatically, but as a first step we need to implement those
that aren't yet. This is what this PR introduces.

## Test code and steps to reproduce

Go through Example app, nothing should change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants