feat: proper snapshot when having multiple modals #2121
Conversation
| if (_presentedModals.count < 2) { | ||
| _snapshot = [_controller.visibleViewController.view snapshotViewAfterScreenUpdates:NO]; | ||
| } else { | ||
| _snapshot = [[_presentedModals.lastObject view] snapshotViewAfterScreenUpdates:NO]; | ||
| } |
There was a problem hiding this comment.
Yeah, I see.
There, most likely, still will be an issue when we dismiss a modal from different stack. I believe you can test this on Test1829 (if not present in FabricTestExample it is in TestsExample).
There was a problem hiding this comment.
Yep, it does not work in such case, do we want to handle it right now?
There was a problem hiding this comment.
I think we won't be really able to come up with anything different that a heuristic solution before we do proper modal presenting logic refactor.
Let's proceed now, I'll create note on our task board so that this is not forgotten.
| if (_presentedModals.count < 2) { | ||
| _snapshot = [_controller.visibleViewController.view snapshotViewAfterScreenUpdates:NO]; | ||
| } else { | ||
| _snapshot = [[_presentedModals.lastObject view] snapshotViewAfterScreenUpdates:NO]; | ||
| } |
There was a problem hiding this comment.
I think we won't be really able to come up with anything different that a heuristic solution before we do proper modal presenting logic refactor.
Let's proceed now, I'll create note on our task board so that this is not forgotten.
Description
PR handling setting a proper snapshot of a modal when it is dismissed from JS on new arch. Still does not work with
Test1829Changes
Test code and steps to reproduce
Checklist