feat: remove currentBridge occurences #2120
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WoLewicki
commented
May 7, 2024
| RNSScreenViewEvent *event = [[RNSScreenViewEvent alloc] initWithEventName:@"onTransitionProgress" | ||
| reactTag:[NSNumber numberWithInt:self.tag] | ||
| progress:progress | ||
| closing:closing | ||
| goingForward:goingForward]; | ||
| [[RCTBridge currentBridge].eventDispatcher notifyObserversOfEvent:event]; | ||
| NSDictionary *userInfo = [NSDictionary dictionaryWithObjectsAndKeys:event, @"event", nil]; |
There was a problem hiding this comment.
For now it only work on bridgeless mode so we prolly need to find some other way to make it work.
|
We have to wait for facebook/react-native#44474 to be released to properly handle all of this. |
|
Is this PR still relevant? Let me know whether I should attempt reviewing this PR |
|
Nope, we should close it. I'll have to check what is the state of those things and if they are properly handled right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR removing occurences of
currentBridgein the code since we should not use it (see software-mansion/react-native-reanimated#5497 (comment)). Now inRNSScreen.mmwe use the same hack asScrollView(see the comment in the code).RNSModulenow has thesetBridgemethod so it gets the bridge on new arch in bridgeless too. As forRNSScreenStackHeaderSubview, I removed the call and changed it tonilsince it did not work either way on new arch.Changes
Test code and steps to reproduce
Checklist