-
-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bring 0.74 support #2047
Merged
Merged
feat: bring 0.74 support #2047
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
bcce50c
feat: FabricTestExample not working with safe area context
WoLewicki aae5f24
feat: FabricExample without safe area context
WoLewicki 2f27ed3
fix: fixes for bridgeless on 74
WoLewicki f85ee9a
fix: more changes to make it work
WoLewicki 817e9a9
fix: uncomment modules
WoLewicki fba7967
Update FabricExample/ios/FabricExample/Info.plist
WoLewicki 98ecee1
chore: bump FabricTestExample to rc2
WoLewicki 0a289c8
chore: bump FabricExample to rc2
WoLewicki b7c8cd5
feat: use latest xcode
WoLewicki 19b4987
chore: indent and unused code
WoLewicki File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,42 +1,86 @@ | ||
| import React from 'react'; | ||
| import {createNativeStackNavigator} from '@react-navigation/native-stack'; | ||
| import {NavigationContainer} from '@react-navigation/native'; | ||
| import {I18nManager} from 'react-native'; | ||
| import Chapter from './src/Chapter'; | ||
| import chapters from './src/chapters'; | ||
| import HeaderDemo from './src/HeaderDemo'; | ||
| import {WHITE} from './src/colors'; | ||
| // import React from 'react'; | ||
| // import {createNativeStackNavigator} from '@react-navigation/native-stack'; | ||
| // import {NavigationContainer} from '@react-navigation/native'; | ||
| // import {I18nManager} from 'react-native'; | ||
| // import Chapter from './src/Chapter'; | ||
| // import chapters from './src/chapters'; | ||
| // import HeaderDemo from './src/HeaderDemo'; | ||
| // import {WHITE} from './src/colors'; | ||
|
|
||
| // const Stack = createNativeStackNavigator(); | ||
|
|
||
| // const App = () => ( | ||
| // <NavigationContainer> | ||
| // <Stack.Navigator | ||
| // screenOptions={{ | ||
| // headerHideBackButton: true, | ||
| // direction: I18nManager.isRTL ? 'rtl' : 'ltr', | ||
| // }}> | ||
| // <Stack.Screen | ||
| // name="Chapter" | ||
| // options={{ | ||
| // title: 'Fabric Example', | ||
| // headerShown: false, | ||
| // }} | ||
| // initialParams={{ | ||
| // index: 0, | ||
| // chapters: chapters, | ||
| // chapterRoute: 'Chapter', | ||
| // afterChapterRoute: 'HeaderDemo', | ||
| // }} | ||
| // component={Chapter} | ||
| // /> | ||
| // <Stack.Screen | ||
| // name="HeaderDemo" | ||
| // component={HeaderDemo} | ||
| // options={{title: 'Header Demo', headerTintColor: WHITE}} | ||
| // /> | ||
| // </Stack.Navigator> | ||
| // </NavigationContainer> | ||
| // ); | ||
|
|
||
| const Stack = createNativeStackNavigator(); | ||
| // export default App; | ||
|
|
||
| import React from 'react'; | ||
| import {ScrollView, View} from 'react-native'; | ||
| import {ScreenStack, Screen} from 'react-native-screens'; | ||
|
|
||
| const App = () => ( | ||
| <NavigationContainer> | ||
| <Stack.Navigator | ||
| screenOptions={{ | ||
| headerHideBackButton: true, | ||
| direction: I18nManager.isRTL ? 'rtl' : 'ltr', | ||
| }}> | ||
| <Stack.Screen | ||
| name="Chapter" | ||
| options={{ | ||
| title: 'Fabric Example', | ||
| headerShown: false, | ||
| }} | ||
| initialParams={{ | ||
| index: 0, | ||
| chapters: chapters, | ||
| chapterRoute: 'Chapter', | ||
| afterChapterRoute: 'HeaderDemo', | ||
| }} | ||
| component={Chapter} | ||
| /> | ||
| <Stack.Screen | ||
| name="HeaderDemo" | ||
| component={HeaderDemo} | ||
| options={{title: 'Header Demo', headerTintColor: WHITE}} | ||
| /> | ||
| </Stack.Navigator> | ||
| </NavigationContainer> | ||
| <ScreenStack style={{flex: 1}}> | ||
| {/* <Screen style={{flex: 1}}> | ||
| <View style={{flex: 1, backgroundColor: 'blue'}} /> | ||
| </Screen> */} | ||
| <Screen | ||
| style={{flex: 1}} | ||
| // onHeaderHeightChange={e => { | ||
| // const headerHeight = e.nativeEvent.headerHeight; | ||
| // console.log(headerHeight); | ||
| // // if (cachedAnimatedHeaderHeight.current !== headerHeight) { | ||
| // // Currently, we're setting value by Animated#setValue, because we want to cache animated value. | ||
| // // Also, in React Native 0.72 there was a bug on Fabric causing a large delay between the screen transition, | ||
| // // which should not occur. | ||
| // // TODO: Check if it's possible to replace animated#setValue to Animated#event. | ||
| // // animatedHeaderHeight.setValue(headerHeight); | ||
| // // cachedAnimatedHeaderHeight.current = headerHeight; | ||
| // // } | ||
| // }} | ||
| > | ||
| {/* <ScrollView contentInsetAdjustmentBehavior="automatic"> */} | ||
| <View | ||
| style={{ width: 50, height: 50, backgroundColor: 'blue'}} | ||
| /> | ||
| <View | ||
| style={{ width: 50, height: 50, backgroundColor: 'red'}} | ||
| /> | ||
| <View | ||
| style={{ width: 50, height: 50, backgroundColor: 'red'}} | ||
| /> | ||
| <View | ||
| style={{ width: 50, height: 50, backgroundColor: 'red'}} | ||
| /> | ||
| {/* </ScrollView> */} | ||
| </Screen> | ||
| </ScreenStack> | ||
| ); | ||
|
|
||
| export default App; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,103 @@ | ||
| GEM | ||
| remote: https://rubygems.org/ | ||
| specs: | ||
| CFPropertyList (3.0.7) | ||
| base64 | ||
| nkf | ||
| rexml | ||
| activesupport (7.0.8.1) | ||
| concurrent-ruby (~> 1.0, >= 1.0.2) | ||
| i18n (>= 1.6, < 2) | ||
| minitest (>= 5.1) | ||
| tzinfo (~> 2.0) | ||
| addressable (2.8.6) | ||
| public_suffix (>= 2.0.2, < 6.0) | ||
| algoliasearch (1.27.5) | ||
| httpclient (~> 2.8, >= 2.8.3) | ||
| json (>= 1.5.1) | ||
| atomos (0.1.3) | ||
| base64 (0.2.0) | ||
| claide (1.1.0) | ||
| cocoapods (1.15.2) | ||
| addressable (~> 2.8) | ||
| claide (>= 1.0.2, < 2.0) | ||
| cocoapods-core (= 1.15.2) | ||
| cocoapods-deintegrate (>= 1.0.3, < 2.0) | ||
| cocoapods-downloader (>= 2.1, < 3.0) | ||
| cocoapods-plugins (>= 1.0.0, < 2.0) | ||
| cocoapods-search (>= 1.0.0, < 2.0) | ||
| cocoapods-trunk (>= 1.6.0, < 2.0) | ||
| cocoapods-try (>= 1.1.0, < 2.0) | ||
| colored2 (~> 3.1) | ||
| escape (~> 0.0.4) | ||
| fourflusher (>= 2.3.0, < 3.0) | ||
| gh_inspector (~> 1.0) | ||
| molinillo (~> 0.8.0) | ||
| nap (~> 1.0) | ||
| ruby-macho (>= 2.3.0, < 3.0) | ||
| xcodeproj (>= 1.23.0, < 2.0) | ||
| cocoapods-core (1.15.2) | ||
| activesupport (>= 5.0, < 8) | ||
| addressable (~> 2.8) | ||
| algoliasearch (~> 1.0) | ||
| concurrent-ruby (~> 1.1) | ||
| fuzzy_match (~> 2.0.4) | ||
| nap (~> 1.0) | ||
| netrc (~> 0.11) | ||
| public_suffix (~> 4.0) | ||
| typhoeus (~> 1.0) | ||
| cocoapods-deintegrate (1.0.5) | ||
| cocoapods-downloader (2.1) | ||
| cocoapods-plugins (1.0.0) | ||
| nap | ||
| cocoapods-search (1.0.1) | ||
| cocoapods-trunk (1.6.0) | ||
| nap (>= 0.8, < 2.0) | ||
| netrc (~> 0.11) | ||
| cocoapods-try (1.2.0) | ||
| colored2 (3.1.2) | ||
| concurrent-ruby (1.2.3) | ||
| escape (0.0.4) | ||
| ethon (0.16.0) | ||
| ffi (>= 1.15.0) | ||
| ffi (1.16.3) | ||
| fourflusher (2.3.1) | ||
| fuzzy_match (2.0.4) | ||
| gh_inspector (1.1.3) | ||
| httpclient (2.8.3) | ||
| i18n (1.14.1) | ||
| concurrent-ruby (~> 1.0) | ||
| json (2.7.1) | ||
| minitest (5.22.2) | ||
| molinillo (0.8.0) | ||
| nanaimo (0.3.0) | ||
| nap (1.1.0) | ||
| netrc (0.11.0) | ||
| nkf (0.2.0) | ||
| public_suffix (4.0.7) | ||
| rexml (3.2.6) | ||
| ruby-macho (2.5.1) | ||
| typhoeus (1.4.1) | ||
| ethon (>= 0.9.0) | ||
| tzinfo (2.0.6) | ||
| concurrent-ruby (~> 1.0) | ||
| xcodeproj (1.24.0) | ||
| CFPropertyList (>= 2.3.3, < 4.0) | ||
| atomos (~> 0.1.3) | ||
| claide (>= 1.0.2, < 2.0) | ||
| colored2 (~> 3.1) | ||
| nanaimo (~> 0.3.0) | ||
| rexml (~> 3.2.4) | ||
|
|
||
| PLATFORMS | ||
| ruby | ||
|
|
||
| DEPENDENCIES | ||
| activesupport (>= 6.1.7.5, < 7.1.0) | ||
| cocoapods (~> 1.15.2) | ||
|
|
||
| RUBY VERSION | ||
| ruby 3.2.1p31 | ||
|
|
||
| BUNDLED WITH | ||
| 2.4.6 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 0 additions & 20 deletions
20
FabricExample/android/app/src/release/java/com/fabricexample/ReactNativeFlipper.java
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.5-all.zip | ||
WoLewicki marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| networkTimeout=10000 | ||
| validateDistributionUrl=true | ||
| zipStoreBase=GRADLE_USER_HOME | ||
| zipStorePath=wrapper/dists | ||
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to remove that permission?