doc: add kotlin MainActiviy.kt to instructions #1971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sion#1957) ## Description Setting version of JDK to 17 for CI builds as it is required by 0.73 to run. ## Test code and steps to reproduce CI passing should be enough ## Checklist - [ ] Ensured that CI passes
software-mansion#1969) ## Description Currently, in iOS 17.2 Beta 1-2 there's a bug that causes application to crash after going to the second screen with the video player that contains controls. This PR fixes this issue. Closes software-mansion#1967. ## Changes - Added an if statement that returns if view is type of `AVPlayerView`, as we don't want to signal it about decelerating (sadly, this header file is not in UIKit's public API 😕. ## Screenshots / GIFs ### Before https://github.com/software-mansion/react-native-screens/assets/23281839/6d040536-45fb-41ea-ad8a-1c86352bf199 ### After https://github.com/software-mansion/react-native-screens/assets/23281839/6da618e4-2bf9-47fb-be9f-e73ae560f081 ## Test code and steps to reproduce You can test this change on the repro, attached in the original issue: https://github.com/abanobmikaeel/react-native-video-crash/ ## Checklist - [X] Ensured that CI passes
|
Look great, thank you for contributing. I'll merge it to #1956 where we work on support for 0.73 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RN 0.73 has MainActivity in kotlin not java
Changes