Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: downgrade native deps to avoid conflicts with other libs #1943

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

kkafar
Copy link
Member

@kkafar kkafar commented Oct 23, 2023

Description

So I've recently bumped versions of few native library dependencies in #1891, but it also bumped some transitive dependencies that conflicted with lower versions that are required by packages such as gesture-handler, reanimated, safe-area-context etc.
I'm downgrading the versions as much I as can while also keeping possible high material version.

Test code and steps to reproduce

I downgraded kotlin to 1.6.21 in TestsExample && tested the build.

Checklist

  • Ensured that CI passes

@kkafar kkafar requested a review from tboba October 23, 2023 11:05
@kkafar kkafar changed the title fix: resolve dependency conflicts with other libs fix: downgrade native deps to avoid conflicts with other libs Oct 23, 2023
Copy link
Member

@tboba tboba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just checked the change on Example app and it works great! 👍

@kkafar kkafar merged commit e646372 into main Oct 23, 2023
4 checks passed
@kkafar kkafar deleted the @kkafar/fix-android-build branch October 23, 2023 15:39
ja1ns pushed a commit to WiseOwlTech/react-native-screens that referenced this pull request Oct 9, 2024
…re-mansion#1943)

## Description

So I've recently bumped versions of few native library dependencies in
software-mansion#1891, but
it also bumped some transitive dependencies that conflicted with lower
versions that are required by packages such as `gesture-handler`,
`reanimated`, `safe-area-context` etc.
I'm downgrading the versions as much I as can while also keeping
possible high `material` version.

## Test code and steps to reproduce

I downgraded kotlin to `1.6.21` in TestsExample && tested the build.

## Checklist

- [ ] Ensured that CI passes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants