Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Android): Fix calculating header height on status bar / action bar visibility #1921

Closed
wants to merge 18 commits into from
Closed

fix(Android): Fix calculating header height on status bar / action bar visibility #1921

wants to merge 18 commits into from

Conversation

tboba
Copy link
Member

@tboba tboba commented Oct 17, 2023

Description

WIP

Changes

WIP

Test code and steps to reproduce

Checklist

  • Included code example that can be used to test this change
  • Ensured that CI passes

tboba added 18 commits October 11, 2023 10:04
@tboba
Add sending events about header height on setting config and chaning …
83c8abc 
…status bar visibility
@tboba
Change place of updating header height
2d8592c
@tboba
Change vc to self.screenView.controller
dda38c3
@tboba
Change implementation of getCalculatedStatusBarHeightIsModal method
6e3cbb9
@tboba
Remove calculating header height in statusBarHidden
46364e5
@tboba
Refactor naming of methods related to header height
9529047
@tboba
Apply changes from code review
8884bef
@tboba
Remove (RNSScreen *) leftover
40df2fd
@tboba
Fix issue with not counting navigation bar inset in transparent modals
3d4bd36
@tboba
Change self.topViewController to screenController
4f45e5f
@tboba
Change hasModalOpened to assertModalHierarchy, add assertions
9c0a332
@tboba
Add additional checks for calculating header height
e910699
@tboba
Fix negative values counted for the modals
b0243c7
@tboba
Add isModal check
dc987c6
@tboba
Add check if modal is being dismissed to avoid redundant calculations
686a221
@tboba
Remove count == 0 from assertModalHierarchy
e779764
@tboba
Remove checks for childViewController.count, change assertModalHierar…
add6ee3 
…chy to isModalWithHeader, move statusBarSize var
@tboba
Fix calculating dynamic header height on changing status bar / action…
6a56f35 
… bar visibility
@tboba
Copy link
Member Author

tboba commented Oct 17, 2023

Unwanted commit history.

@tboba tboba closed this Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tboba