fix(CI): fix Android E2E Events test #1898
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Every now and then our CI was failing on the specific test -
events.e2e.ts
. The issue was that the toasts that were displayed during the test were dismissed too quickly (even after 40 seconds of waiting).This PR fixes the problem with checking if the application is running on the Detox server.
When I was making that change I was thinking about couple approaches how to detect if the machine that runs the tests is Detox:
❌ Using
react-native-is-detox
lib: I didn't want to have additional lib that seems to be not maintained actively + this approach is error-prone: there's for sure a better alternative than checking the environment natively❌ Using .env files as environment libraries (with
react-native-config
lib): it's a great idea for using multiple values but it's a huge over-exaggerate when dealing only with single state✅ I think using launch arguments is a best approach here, as it is lightweight while using only one value.
Changes
events.e2e.ts
)Checklist