feat(Android): add native default animations on Android 13 #1693

kkafar · 2023-01-21T11:23:25Z

Description

Resolves #1640

Changes

Added new animations definitions (taken from Android Open Source Project repo)
Added interpolator standard_accelerate
Modified code responsible for assigning animations to transactions.

Test code and steps to reproduce

Test1072 works fine (just change stackPresentation to default and see that new animations are used).

Remember to target Android SDK >= 33

Checklist

Ensured that CI passes (CI errors will be handled with chore: fix e2e detox tests & Example #1681)

## Description Bringing examples up to speed with ReactNative & other deps. During testing I noticed that changes introduced in #1693 may cause Android application to crash during build if it is build for sdk < 33. ## Checklist - [x] Ensured that CI passes

## Description #1693 introduced new animation xml's with features available only since API level 33 (Android 13). This resulted in build failures in cases where `compileSdk`/`targetSdk` is set to value lower than 33. Note: placing these animations in qualified resource directory `res/anim-v33` did not resolve the issue, because the qualifier is only used during runtime - in build phase all resources must be valid from the perspective of given SDK (at least it seems so). I thought of few options: 1. Having separate `res` directories for `compileSdk >= 33` and `compileSdk < 33` and selecting appropriate in `build.gradle`. The main disadvantage is that most of the animation resources are being duplicated and any future modifications will require us to remember to modify both versions of resources. 2. Keeping only new animation files in separate directory and copying them into `res/anim-v33` **during gradle configuration phase** only when appropriate. This also would require us to modify files in two places, but only few ones, which is slightly better IMO. The emphasis on configuration phase comes from the fact, that it will work Android Studio nicely (`gradle sync`). As for now I went with option 2. ## Changes Added `manageV33Animations` task to `build.gradle` which: 1. Copies v33 xmls inside `res/anim-v33` when `compileSdk >= 33` 2. Deletes `res/anim-v33` when `compileSdk < 33` ## Test code and steps to reproduce Build any Android example with various `compileSdk` set and observe how resource files change (also check out #1693) ## Checklist - [x] Ensured that CI passes

## Description New Android animations introduced in #1693 were laggy (especially enter-out / enter-in animations). This was caused by [these lines](https://cs.android.com/android/platform/superproject/+/android-platform-13.0.0_r6:frameworks/base/core/res/res/anim/activity_open_exit.xml;l=23-24) in Android source code -- alpha was not animated. ## Changes Set more reasonable target value for alpha animation & explicitly set start offset on enter out animation. ## Test code and steps to reproduce See #1693 for description. ## Checklist - [x] Ensured that CI passes (Android e2e do fail for unrelated reasons)

## Description software-mansion/react-native-screens#1693 introduced new animation xml's with features available only since API level 33 (Android 13). This resulted in build failures in cases where `compileSdk`/`targetSdk` is set to value lower than 33. Note: placing these animations in qualified resource directory `res/anim-v33` did not resolve the issue, because the qualifier is only used during runtime - in build phase all resources must be valid from the perspective of given SDK (at least it seems so). I thought of few options: 1. Having separate `res` directories for `compileSdk >= 33` and `compileSdk < 33` and selecting appropriate in `build.gradle`. The main disadvantage is that most of the animation resources are being duplicated and any future modifications will require us to remember to modify both versions of resources. 2. Keeping only new animation files in separate directory and copying them into `res/anim-v33` **during gradle configuration phase** only when appropriate. This also would require us to modify files in two places, but only few ones, which is slightly better IMO. The emphasis on configuration phase comes from the fact, that it will work Android Studio nicely (`gradle sync`). As for now I went with option 2. ## Changes Added `manageV33Animations` task to `build.gradle` which: 1. Copies v33 xmls inside `res/anim-v33` when `compileSdk >= 33` 2. Deletes `res/anim-v33` when `compileSdk < 33` ## Test code and steps to reproduce Build any Android example with various `compileSdk` set and observe how resource files change (also check out #1693) ## Checklist - [x] Ensured that CI passes

## Description New Android animations introduced in software-mansion/react-native-screens#1693 were laggy (especially enter-out / enter-in animations). This was caused by [these lines](https://cs.android.com/android/platform/superproject/+/android-platform-13.0.0_r6:frameworks/base/core/res/res/anim/activity_open_exit.xml;l=23-24) in Android source code -- alpha was not animated. ## Changes Set more reasonable target value for alpha animation & explicitly set start offset on enter out animation. ## Test code and steps to reproduce See #1693 for description. ## Checklist - [x] Ensured that CI passes (Android e2e do fail for unrelated reasons)

Add animations definitions

3648616

kkafar self-assigned this Jan 21, 2023

kkafar added 7 commits January 21, 2023 13:09

Use Android 13 animations when app builded for API level >= TIRAMISU

7b2cc7a

Fix animations schemas to use existing interpolators

96050fb

Use custom standard accelerate interpolator

58225d8

Categorize resources with API specifiers

4f22bbe

Remove redundant api level check

70e0719

Update targetApi for Android build in Example app

8b0a757

Try to adjust emulator configuration|

d805f96

kkafar merged commit bd0c957 into main Jan 31, 2023

kkafar deleted the @kkafar/fix-android-transitions-1640 branch January 31, 2023 13:58

kkafar mentioned this pull request Feb 7, 2023

chore: update deps in examples #1714

Merged

1 task

kkafar mentioned this pull request Feb 23, 2023

fix: Android build for compileSdk < 33 #1723

Merged

1 task

kkafar mentioned this pull request Apr 13, 2023

chore: improve Android 13 animations #1756

Merged

1 task

philiplindberg mentioned this pull request Aug 31, 2023

Native Stack Navigator screen transitions still don't match system transitions on Android 13 #1879

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(Android): add native default animations on Android 13 #1693

feat(Android): add native default animations on Android 13 #1693

kkafar commented Jan 21, 2023 •

edited

Loading

feat(Android): add native default animations on Android 13 #1693

feat(Android): add native default animations on Android 13 #1693

Conversation

kkafar commented Jan 21, 2023 • edited Loading

Description

Changes

Test code and steps to reproduce

Checklist

kkafar commented Jan 21, 2023 •

edited

Loading